Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite waste types #500

Open
hilsonp opened this issue Aug 23, 2024 · 2 comments
Open

Overwrite waste types #500

hilsonp opened this issue Aug 23, 2024 · 2 comments

Comments

@hilsonp
Copy link

hilsonp commented Aug 23, 2024

Hello,

Can we overwrite waste type strings by configuration ?
For example, WASTE_TYPE_GREY is 'Restafval' and I would like to set it to 'Ordures-Ménagères' or simply 'Grises'.

Thank you,

Pierre

@pippyn
Copy link
Owner

pippyn commented Aug 26, 2024

Hi Pierre,

Thanks for your question. At the moment the french translation is not finished yet. It still needs some work. For now you can create template sensors to translate the states in your desired naming.

@hilsonp
Copy link
Author

hilsonp commented Aug 27, 2024

Hello,

Thank you for your reply.

Addressing this through translation(s) might be a never ending story as there are many languages out there.
Additionally, one may not like the term you would have implemented.

This is why I thought that being able to provide custom names for wasted types would suit every one needs without requiring (yet another) template.

This is already defined as a series of constants in the code and thought it would be really easy to externalise in a configuration file.

Well. I hear you. I should submit a PR 😌

Thank you anyway for your nice work 👍

This comment is ment to be constructive and is not a critiscism or a complaint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants