Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support async spanEvent tracing after ChildTrace closed #253

Closed
feelform opened this issue Dec 26, 2024 · 0 comments · Fixed by #252
Closed

Support async spanEvent tracing after ChildTrace closed #253

feelform opened this issue Dec 26, 2024 · 0 comments · Fixed by #252

Comments

@feelform
Copy link
Collaborator 

async function() {
    await axios.get(`https://www.naver.com`, { httpsAgent: new https.Agent({ keepAlive: false }) })
    req.cache.expire(key, 10, function (err, data) {})
}

When async function was ran, The req.cache.expire SpanChunk lost. The Java agent stackDump creates dummySpanEvent() in ChildTrace.java.

The NodeJS have to support async function after parent ChildTrace was close event.
feelform added a commit to feelform/pinpoint-node-agent that referenced this issue Dec 26, 2024
@feelform
[pinpoint-apm#253] Support async spanEvent tracing after ChildTrace c…
d025627 
…losed
feelform added a commit to feelform/pinpoint-node-agent that referenced this issue Dec 26, 2024
@feelform
[pinpoint-apm#253] Support async spanEvent tracing after ChildTrace c…
0232239 
…losed

[pinpoint-apm#251] Fix SQL-ID not found sqlId:1 bug
* GrpcDataSender fixtures close resources
* Functional Test port number
*  spanChunk Trace by asyncId
@feelform feelform linked a pull request Dec 26, 2024 that will close this issue
[#251] Fix SQL-ID not found sqlId:1 bug #252
Merged
feelform added a commit that referenced this issue Dec 26, 2024
@feelform
[#253] Support async spanEvent tracing after ChildTrace closed
9799b40 
[#251] Fix SQL-ID not found sqlId:1 bug
* GrpcDataSender fixtures close resources
* Functional Test port number
*  spanChunk Trace by asyncId
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#251] Fix SQL-ID not found sqlId:1 bug feelform/pinpoint-node-agent
1 participant
@feelform