From f31ba90573e76d712e25d8b7d9800783bfd2925a Mon Sep 17 00:00:00 2001 From: nohli <43643339+nohli@users.noreply.github.com> Date: Sat, 5 Jun 2021 14:58:52 +0200 Subject: [PATCH 1/5] Run dartfmt --- example/test/widget_test.dart | 4 ++-- lib/flutter_native_timezone_web.dart | 16 ++++++---------- test/flutter_native_timezone_test.dart | 2 +- 3 files changed, 9 insertions(+), 13 deletions(-) diff --git a/example/test/widget_test.dart b/example/test/widget_test.dart index 3d18851..b3fca04 100644 --- a/example/test/widget_test.dart +++ b/example/test/widget_test.dart @@ -10,8 +10,8 @@ void main() { // Verify that platform version is retrieved. expect( find.byWidgetPredicate( - (Widget widget) => - widget is Text && + (Widget widget) => + widget is Text && widget.data?.startsWith('Local timezone:') == true, ), findsOneWidget, diff --git a/lib/flutter_native_timezone_web.dart b/lib/flutter_native_timezone_web.dart index 9f45ab4..81a4f92 100644 --- a/lib/flutter_native_timezone_web.dart +++ b/lib/flutter_native_timezone_web.dart @@ -11,10 +11,8 @@ import 'package:js/js.dart'; /// class FlutterNativeTimezonePlugin { static void registerWith(Registrar registrar) { - final MethodChannel channel = MethodChannel( - 'flutter_native_timezone', - const StandardMethodCodec(), - registrar.messenger); + final MethodChannel channel = MethodChannel('flutter_native_timezone', + const StandardMethodCodec(), registrar.messenger); final FlutterNativeTimezonePlugin instance = FlutterNativeTimezonePlugin(); channel.setMethodCallHandler(instance.handleMethodCall); } @@ -24,11 +22,12 @@ class FlutterNativeTimezonePlugin { case 'getLocalTimezone': return _getLocalTimeZone(); case 'getAvailableTimezones': - return [ _getLocalTimeZone() ]; + return [_getLocalTimeZone()]; default: throw PlatformException( code: 'Unimplemented', - details: "The flutter_native_timezone plugin for web doesn't implement " + details: + "The flutter_native_timezone plugin for web doesn't implement " "the method '${call.method}'"); } } @@ -37,9 +36,7 @@ class FlutterNativeTimezonePlugin { /// local time zone when running on the web. /// String _getLocalTimeZone() { - return jsDateTimeFormat() - .resolvedOptions() - .timeZone; + return jsDateTimeFormat().resolvedOptions().timeZone; } } @@ -57,4 +54,3 @@ abstract class _JSResolvedOptions { @JS() external String get timeZone; } - diff --git a/test/flutter_native_timezone_test.dart b/test/flutter_native_timezone_test.dart index 0ad208b..64e16bc 100644 --- a/test/flutter_native_timezone_test.dart +++ b/test/flutter_native_timezone_test.dart @@ -4,7 +4,7 @@ import 'package:flutter_test/flutter_test.dart'; void main() { TestWidgetsFlutterBinding.ensureInitialized(); - + const MethodChannel channel = MethodChannel('flutter_native_timezone'); setUp(() { From f8e6e3281c92c2abca437229a067e9137e189cf7 Mon Sep 17 00:00:00 2001 From: nohli <43643339+nohli@users.noreply.github.com> Date: Sat, 5 Jun 2021 14:59:27 +0200 Subject: [PATCH 2/5] Remove unused import --- lib/flutter_native_timezone_web.dart | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/flutter_native_timezone_web.dart b/lib/flutter_native_timezone_web.dart index 81a4f92..0d82b08 100644 --- a/lib/flutter_native_timezone_web.dart +++ b/lib/flutter_native_timezone_web.dart @@ -1,5 +1,4 @@ import 'dart:async'; -import 'dart:html' as html; import 'package:flutter/services.dart'; import 'package:flutter_web_plugins/flutter_web_plugins.dart'; From 343e5e2af7dbf9a630b729a187eb2ad6e696ca89 Mon Sep 17 00:00:00 2001 From: nohli <43643339+nohli@users.noreply.github.com> Date: Sat, 5 Jun 2021 15:00:25 +0200 Subject: [PATCH 3/5] Remove deprecated .messenger --- lib/flutter_native_timezone_web.dart | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/flutter_native_timezone_web.dart b/lib/flutter_native_timezone_web.dart index 0d82b08..394aa41 100644 --- a/lib/flutter_native_timezone_web.dart +++ b/lib/flutter_native_timezone_web.dart @@ -10,8 +10,11 @@ import 'package:js/js.dart'; /// class FlutterNativeTimezonePlugin { static void registerWith(Registrar registrar) { - final MethodChannel channel = MethodChannel('flutter_native_timezone', - const StandardMethodCodec(), registrar.messenger); + final MethodChannel channel = MethodChannel( + 'flutter_native_timezone', + const StandardMethodCodec(), + registrar, + ); final FlutterNativeTimezonePlugin instance = FlutterNativeTimezonePlugin(); channel.setMethodCallHandler(instance.handleMethodCall); } From a027511e6a815b55eaba22361d736cdca681b049 Mon Sep 17 00:00:00 2001 From: nohli <43643339+nohli@users.noreply.github.com> Date: Sat, 5 Jun 2021 15:02:08 +0200 Subject: [PATCH 4/5] Update package description to have >= 60 characters --- pubspec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pubspec.yaml b/pubspec.yaml index 050fe4a..d0dbe3f 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,5 +1,5 @@ name: flutter_native_timezone -description: A flutter plugin for getting the local timezone of the os. +description: A flutter plugin for getting the local timezone of the device. version: 2.0.0 homepage: https://github.com/pinkfish/flutter_native_timezone From 3ec7cc7122a1ba87c06ef009186f1788fc80da0f Mon Sep 17 00:00:00 2001 From: nohli <43643339+nohli@users.noreply.github.com> Date: Sat, 5 Jun 2021 15:02:48 +0200 Subject: [PATCH 5/5] Update version and changelog --- CHANGELOG.md | 4 ++++ pubspec.yaml | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 54bded7..fd74ed6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,7 @@ +## 2.0.1 + +Improve pub.dev score + ## 2.0.0 * Update gradle diff --git a/pubspec.yaml b/pubspec.yaml index d0dbe3f..aa75eee 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,6 +1,6 @@ name: flutter_native_timezone description: A flutter plugin for getting the local timezone of the device. -version: 2.0.0 +version: 2.0.1 homepage: https://github.com/pinkfish/flutter_native_timezone environment: