-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TODO list after normalize pdclient to client-java #2521
Comments
TiFlash cache missing needs to fix. [TISPARK-488] Fix TiFlash region cache #1380 Temporarily fixed in TiSpark If the retry logic of batchGet is added upstream. Re-check the test result of batchGetRetryTest. Restore the test or modify/delete the test tikv/client-java#645 Fix region manager race: #1987. (seems has done in client-java)
fix region may be missed: #2433 support log desensitization: #1798 Fix ResolveLock not called in Scan API #2089
|
Sometimes, it is difficult to judge which is better (TiSpark or client-java), for example, return null or throw an exception; whether retry for a certain error
|
The previous integration test table was not found whether it was caused by a cache miss I found that the integration test on jenkins seems to be refactored once? (curious) |
table not found may not result from the cache miss. it supposed to be fixed in this pr tikv/client-java#670. integration test should not be refactored. |
All things have been done or a corresponding issue has been opend |
com.pingcap.tikv.util.ConvertUpstreamUtils.isTiKVVersionGreatEqualThanVersion
method: If the upstream changes the method name fromStoreVersion.minTiKVVersion
toStoreVersion.isTiKVVersionGreatEqualThanVersion
, remove this method and use the upstream method directly. change method name StoreVersion.minTiKVVersion to StoreVersion.isTi… tikv/client-java#647TiDBOptions
txnPrewriteBatchSize
,txnCommitBatchSize
,writeBufferSize
,writeThreadPerTask
,retryCommitSecondaryKey
,prewriteMaxRetryTimes
are deleted, because these configuration items involve the private constructor of TwoPhaseCommitter. Upstream does not provide a public constructor for use. Temporarily disable the settings of several configuration items to restore the upstream updated configuration. (recovery of documents involved).TiFlash cache missing need to fix. [TISPARK-488] Fix TiFlash region cache #1380 Temporarily fixed in TiSpark.
If the retry logic of batchGet is added upstream. Re-check the test result of
batchGetRetryTest
. Restore the test or modify/delete the test [fix #643] fix retry with resolvedlocks info tikv/client-java#645According to the removed class by #2491, the following prs need to be paid attention to. we need to judge if they are needed to port to upstream.

Retry
Region manager
Fix region manager race: Fix region manager race #1987
Optimize region cache miss:Optimize region cache miss #2106 + fix not leader error due to region not invalidatedhttps://github.com/Fix not leader error due to region not invalidated #2135
fix region may be missed: fix region may be missed #2433
support log desensitization: support log desensitization #1798
Fix ResolveLock not called in Scan API Fix ResolveLock not called in Scan API #2089
fix region may be missed fix region may be missed #2433 (done)
Make TiSpark's Explain clearer and easier to read: Make TiSpark's Explain clearer and easier to read #2439
support clustered index support clustered index #1915 ( maintain CoprocessorIterator in TiSpark or upstream ?)
The text was updated successfully, but these errors were encountered: