Support nesting customer objects again #566
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
isn't that even a bugfix? |
@fashxp I depends if the limitation was deliberate or not I gues, your call. |
|
I would vote for bugfix, could you please rebase? |
|
@fashxp onto which branch? 4.2 ? |
|
yes please |
|
thx very much ❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR the
DefaultObjectNamingSchemesupports nesting Customer objects again - like it was possible in v3.In Pimcore 11 stricter return types got introduced, which may result in a return type error, if customers got saved within other customer objects and not within folders.
There is a possible return type missmatch in https://github.com/pimcore/pimcore/blob/11.5/models/Element/Service.php#L817 and https://github.com/pimcore/pimcore/blob/11.5/models/Element/Service.php#L842. Also see https://github.com/pimcore/pimcore/blob/11.5/models/Element/Service.php#L427