Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Are you serious? #123

Open
stan-ko opened this issue Feb 5, 2016 · 1 comment
Open

Are you serious? #123

stan-ko opened this issue Feb 5, 2016 · 1 comment

Comments

@stan-ko
Copy link

stan-ko commented Feb 5, 2016

You keep an Activity in a static reference in UpdateChecker class - are you an Android developer really?
@Aditya94A
Copy link

Agreed. Everything is needlessly static. Although, there's nothing wrong with that but if you're going to go down that road then a public static init() method is more appropriate than using a constructor. Not to mention the static activity reference is passed on to an AsyncTask without any attempts at cleaning up which could lead to memory leaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stan-ko @Aditya94A