From f004b140f36ea675f9a6e7ee30c8203718d74112 Mon Sep 17 00:00:00 2001 From: llprn Date: Mon, 13 Feb 2023 18:30:31 +0900 Subject: [PATCH 1/2] =?UTF-8?q?refactor:=20=EC=A3=BC=EB=AC=B8=20=EC=83=81?= =?UTF-8?q?=EC=84=B8=20=EB=82=B4=EC=97=AD=20=EC=88=98=EC=A0=95?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../dress/controller/DressController.java | 10 ++++------ .../pickle/server/dress/dto/DressOrderDto.java | 18 ++++++++---------- .../dress/repository/DressDslRepository.java | 2 +- .../dress/repository/DressRepositoryImpl.java | 4 ++-- .../server/dress/service/DressService.java | 5 +++-- 5 files changed, 18 insertions(+), 21 deletions(-) diff --git a/src/main/java/com/pickle/server/dress/controller/DressController.java b/src/main/java/com/pickle/server/dress/controller/DressController.java index 99c7b1f..325ea45 100644 --- a/src/main/java/com/pickle/server/dress/controller/DressController.java +++ b/src/main/java/com/pickle/server/dress/controller/DressController.java @@ -141,13 +141,11 @@ public ResponseEntity> findDressLikeByUser(@ApiIgnore @Authen @ApiResponses({ @ApiResponse(code = 200, message = "의상 예약 상세 내역 조회 성공") }) - @GetMapping("/orders") - public ResponseEntity> getOrder (@ApiIgnore @AuthenticationPrincipal User user){ - return new ResponseEntity<>(dressService.getDressOrder(user.getId()), HttpStatus.OK); + @GetMapping("/orders/{dress_reservation_id}") + public ResponseEntity> getOrder(@PathVariable(name="dress_reservation_id") Long dressReservationId, @ApiIgnore @AuthenticationPrincipal User user){ + return new ResponseEntity<>(dressService.getDressOrder(dressReservationId,user.getId()), HttpStatus.OK); } - - @ApiOperation(value = "의상 예약 내역 조회", httpMethod = "GET", response = DressOrderDto.class, @@ -157,7 +155,7 @@ public ResponseEntity> getOrder (@ApiIgnore @AuthenticationP @ApiResponse(code = 200, message = "의상 예약 내역 조회 성공") }) @GetMapping("/order-list") - public ResponseEntity> getOrderList (@ApiIgnore @AuthenticationPrincipal User user){ + public ResponseEntity> getOrderList(@ApiIgnore @AuthenticationPrincipal User user){ return new ResponseEntity<>(dressService.getDressOrderList(user.getId()), HttpStatus.OK); } } diff --git a/src/main/java/com/pickle/server/dress/dto/DressOrderDto.java b/src/main/java/com/pickle/server/dress/dto/DressOrderDto.java index 1f1937f..de936df 100644 --- a/src/main/java/com/pickle/server/dress/dto/DressOrderDto.java +++ b/src/main/java/com/pickle/server/dress/dto/DressOrderDto.java @@ -12,7 +12,6 @@ import java.time.format.DateTimeFormatter; - @Getter public class DressOrderDto { @ApiModelProperty(example = "예약내역 id") @@ -55,18 +54,17 @@ public class DressOrderDto { @JsonProperty("price") private String price; - @ApiModelProperty(example = "드레스 옵션 1") - @JsonProperty("dress_option1") - private String dressOption1; +// @ApiModelProperty(example = "드레스 옵션 1") +// @JsonProperty("dress_option1") +// private String dressOption1; @ApiModelProperty(example = "드레스 옵션 1_name") @JsonProperty("dress_option1_name") -// private DressOptionDetail dressOption1; private String dressOptionName1; - @ApiModelProperty(example = "드레스 옵션 2") - @JsonProperty("dress_option2") - private String dressOption2; +// @ApiModelProperty(example = "드레스 옵션 2") +// @JsonProperty("dress_option2") +// private String dressOption2; @ApiModelProperty(example = "드레스 옵션 2_name") @JsonProperty("dress_option2_name") // private DressOptionDetail dressOption1; @@ -90,9 +88,9 @@ public DressOrderDto(DressReservation dressReservation, ReservedDress reservedDr + dressReservation.getStore().getCloseTime().format(DateTimeFormatter.ofPattern("HH:mm")); this.storeOpenDay = makeStoreOpenDayIntroduction(dressReservation.getStore().getStoreOpenDay()); this.pickUpDateTime = dressReservation.getPickUpDateTime().toString(); - this.dressOption1 = reservedDress.getDressOptionDetail1().getDressOption().getName(); +// this.dressOption1 = reservedDress.getDressOptionDetail1().getDressOption().getName(); this.dressOptionName1 = reservedDress.getDressOptionDetail1().getName(); - this.dressOption2 = reservedDress.getDressOptionDetail2().getDressOption().getName(); +// this.dressOption2 = reservedDress.getDressOptionDetail2().getDressOption().getName(); this.dressOptionName2 = reservedDress.getDressOptionDetail2().getName(); this.comment =dressReservation.getComment(); this.price = priceFormat.format(dressReservation.getPrice()*reservedDress.getQuantity())+"원"; diff --git a/src/main/java/com/pickle/server/dress/repository/DressDslRepository.java b/src/main/java/com/pickle/server/dress/repository/DressDslRepository.java index 6788130..bee9fa4 100644 --- a/src/main/java/com/pickle/server/dress/repository/DressDslRepository.java +++ b/src/main/java/com/pickle/server/dress/repository/DressDslRepository.java @@ -17,6 +17,6 @@ public interface DressDslRepository { List findDressByStoreAndCreatedAt(Long userId, Double latitude, Double longitude, LocalDateTime stdDate); List findDressByCategory(Long userId, String category, Double latitude, Double longitude); - List findReservationByUser(Long userId); + List findReservationByUserAndReservationId(Long dressReservationId,Long userId); List findReservationListByUser(Long userId); } diff --git a/src/main/java/com/pickle/server/dress/repository/DressRepositoryImpl.java b/src/main/java/com/pickle/server/dress/repository/DressRepositoryImpl.java index e5c1977..db15432 100644 --- a/src/main/java/com/pickle/server/dress/repository/DressRepositoryImpl.java +++ b/src/main/java/com/pickle/server/dress/repository/DressRepositoryImpl.java @@ -195,7 +195,7 @@ private NumberExpression radianToDegree(NumberExpression radian) return radian.multiply(180 / Math.PI); } @Override - public List findReservationByUser(Long userId) { + public List findReservationByUserAndReservationId(Long dressReservationId,Long userId) { return queryFactory .select(new QDressOrderDto( dressReservation,reservedDress, @@ -204,7 +204,7 @@ public List findReservationByUser(Long userId) { .where(dressImage.dress.id.eq(dress.id)).limit(1) )) .from(dressReservation, reservedDress) - .where(dressReservation.user.id.eq(userId)) + .where(dressReservation.user.id.eq(userId).and(dressReservation.id.eq(dressReservationId))) .where(dressReservation.id.eq(reservedDress.dressReservation.id)) .fetch(); } diff --git a/src/main/java/com/pickle/server/dress/service/DressService.java b/src/main/java/com/pickle/server/dress/service/DressService.java index d63e541..f69310c 100644 --- a/src/main/java/com/pickle/server/dress/service/DressService.java +++ b/src/main/java/com/pickle/server/dress/service/DressService.java @@ -102,9 +102,10 @@ public void makeDressReservation(DressReservationDto dressReservationDto, User u } } - public List getDressOrder(Long userId){ + public List getDressOrder(Long dressReservationId,Long userId){ User user = userRepository.findById(userId).orElseThrow(() -> new NotFoundIdException()); - return dressRepository.findReservationByUser(userId); + + return dressRepository.findReservationByUserAndReservationId(dressReservationId,userId); } public List getDressOrderList(Long userId){ User user = userRepository.findById(userId).orElseThrow(() -> new NotFoundIdException()); From 2050c364853a7c77e4e6a00d6a8844bc7158487a Mon Sep 17 00:00:00 2001 From: llprn Date: Mon, 13 Feb 2023 18:50:08 +0900 Subject: [PATCH 2/2] =?UTF-8?q?refactor:=20=EC=A3=BC=EB=AC=B8=20=EB=82=B4?= =?UTF-8?q?=EC=97=AD=20=EB=AA=A9=EB=A1=9D=20=EC=A1=B0=ED=9A=8C=20api-?= =?UTF-8?q?=EC=A3=BC=EB=AC=B8=20=EC=83=81=ED=83=9C=20=EC=A1=B0=EA=B1=B4=20?= =?UTF-8?q?=EC=B6=94=EA=B0=80?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../pickle/server/dress/controller/DressController.java | 7 ++++--- .../pickle/server/dress/repository/DressDslRepository.java | 2 +- .../server/dress/repository/DressRepositoryImpl.java | 3 ++- .../java/com/pickle/server/dress/service/DressService.java | 4 ++-- 4 files changed, 9 insertions(+), 7 deletions(-) diff --git a/src/main/java/com/pickle/server/dress/controller/DressController.java b/src/main/java/com/pickle/server/dress/controller/DressController.java index 325ea45..8aad5fa 100644 --- a/src/main/java/com/pickle/server/dress/controller/DressController.java +++ b/src/main/java/com/pickle/server/dress/controller/DressController.java @@ -142,7 +142,8 @@ public ResponseEntity> findDressLikeByUser(@ApiIgnore @Authen @ApiResponse(code = 200, message = "의상 예약 상세 내역 조회 성공") }) @GetMapping("/orders/{dress_reservation_id}") - public ResponseEntity> getOrder(@PathVariable(name="dress_reservation_id") Long dressReservationId, @ApiIgnore @AuthenticationPrincipal User user){ + public ResponseEntity> getOrder(@PathVariable(name="dress_reservation_id") Long dressReservationId, + @ApiIgnore @AuthenticationPrincipal User user){ return new ResponseEntity<>(dressService.getDressOrder(dressReservationId,user.getId()), HttpStatus.OK); } @@ -155,7 +156,7 @@ public ResponseEntity> getOrder(@PathVariable(name="dress_re @ApiResponse(code = 200, message = "의상 예약 내역 조회 성공") }) @GetMapping("/order-list") - public ResponseEntity> getOrderList(@ApiIgnore @AuthenticationPrincipal User user){ - return new ResponseEntity<>(dressService.getDressOrderList(user.getId()), HttpStatus.OK); + public ResponseEntity> getOrderList(@RequestParam(name="status")String status,@ApiIgnore @AuthenticationPrincipal User user){ + return new ResponseEntity<>(dressService.getDressOrderList(status,user.getId()), HttpStatus.OK); } } diff --git a/src/main/java/com/pickle/server/dress/repository/DressDslRepository.java b/src/main/java/com/pickle/server/dress/repository/DressDslRepository.java index bee9fa4..5952592 100644 --- a/src/main/java/com/pickle/server/dress/repository/DressDslRepository.java +++ b/src/main/java/com/pickle/server/dress/repository/DressDslRepository.java @@ -18,5 +18,5 @@ public interface DressDslRepository { List findDressByCategory(Long userId, String category, Double latitude, Double longitude); List findReservationByUserAndReservationId(Long dressReservationId,Long userId); - List findReservationListByUser(Long userId); + List findReservationListByStatusAndUser(String status,Long userId); } diff --git a/src/main/java/com/pickle/server/dress/repository/DressRepositoryImpl.java b/src/main/java/com/pickle/server/dress/repository/DressRepositoryImpl.java index db15432..2a2735a 100644 --- a/src/main/java/com/pickle/server/dress/repository/DressRepositoryImpl.java +++ b/src/main/java/com/pickle/server/dress/repository/DressRepositoryImpl.java @@ -210,7 +210,7 @@ public List findReservationByUserAndReservationId(Long dressReser } @Override - public List findReservationListByUser(Long userId) { + public List findReservationListByStatusAndUser(String status,Long userId) { return queryFactory .select(new QDressOrderListDto( dressReservation,reservedDress, @@ -221,6 +221,7 @@ public List findReservationListByUser(Long userId) { .from(dressReservation, reservedDress) .where(dressReservation.user.id.eq(userId)) .where(dressReservation.id.eq(reservedDress.dressReservation.id)) + .where(dressReservation.status.eq(status)) .fetch(); } } diff --git a/src/main/java/com/pickle/server/dress/service/DressService.java b/src/main/java/com/pickle/server/dress/service/DressService.java index f69310c..f4c2b9d 100644 --- a/src/main/java/com/pickle/server/dress/service/DressService.java +++ b/src/main/java/com/pickle/server/dress/service/DressService.java @@ -107,8 +107,8 @@ public List getDressOrder(Long dressReservationId,Long userId){ return dressRepository.findReservationByUserAndReservationId(dressReservationId,userId); } - public List getDressOrderList(Long userId){ + public List getDressOrderList(String status,Long userId){ User user = userRepository.findById(userId).orElseThrow(() -> new NotFoundIdException()); - return dressRepository.findReservationListByUser(userId); + return dressRepository.findReservationListByStatusAndUser(status,userId); } }