From 948fcd794cc39f9df2891c3e40807e9a3a2ec4e2 Mon Sep 17 00:00:00 2001
From: Phil Shadlyn <phil.shadlyn@shopify.com>
Date: Sun, 24 Nov 2019 09:43:56 -0500
Subject: [PATCH] remove scroll behaviour to not hide FAB on scroll

---
 .../ui/ScrollAwareFabBehaviour.java           | 81 -------------------
 .../main/res/layout/fragment_conversion.xml   |  4 +-
 2 files changed, 1 insertion(+), 84 deletions(-)
 delete mode 100644 app/src/main/java/com/physphil/android/unitconverterultimate/ui/ScrollAwareFabBehaviour.java

diff --git a/app/src/main/java/com/physphil/android/unitconverterultimate/ui/ScrollAwareFabBehaviour.java b/app/src/main/java/com/physphil/android/unitconverterultimate/ui/ScrollAwareFabBehaviour.java
deleted file mode 100644
index 4e1aa364..00000000
--- a/app/src/main/java/com/physphil/android/unitconverterultimate/ui/ScrollAwareFabBehaviour.java
+++ /dev/null
@@ -1,81 +0,0 @@
-/*
- * Copyright 2016 Phil Shadlyn
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *    http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package com.physphil.android.unitconverterultimate.ui;
-
-import android.content.Context;
-import androidx.annotation.NonNull;
-import androidx.coordinatorlayout.widget.CoordinatorLayout;
-import com.google.android.material.floatingactionbutton.FloatingActionButton;
-import androidx.core.view.ViewCompat;
-import android.util.AttributeSet;
-import android.view.View;
-
-/**
- * Behaviour to hide/show FAB on scroll
- * Created by Phizz on 16-09-11.
- */
-public class ScrollAwareFabBehaviour extends FloatingActionButton.Behavior {
-
-    public ScrollAwareFabBehaviour(Context context, AttributeSet attrs) {
-        super();
-    }
-
-    @Override
-    public boolean onStartNestedScroll(
-        @NonNull CoordinatorLayout coordinatorLayout,
-        @NonNull FloatingActionButton child,
-        @NonNull View directTargetChild,
-        @NonNull View target,
-        int axes,
-        int type
-    ) {
-        return axes == ViewCompat.SCROLL_AXIS_VERTICAL ||
-            super.onStartNestedScroll(coordinatorLayout, child, directTargetChild, target, axes, type);
-    }
-
-    @Override
-    public void onNestedScroll(
-        @NonNull CoordinatorLayout coordinatorLayout,
-        @NonNull FloatingActionButton child,
-        @NonNull View target,
-        int dxConsumed,
-        int dyConsumed,
-        int dxUnconsumed,
-        int dyUnconsumed,
-        int type
-    ) {
-        super.onNestedScroll(coordinatorLayout, child, target, dxConsumed, dyConsumed, dxUnconsumed, dyUnconsumed, type);
-
-        if (dyConsumed > 0 && child.getVisibility() == View.VISIBLE) {
-            // User scrolled down and the FAB is currently visible -> hide the FAB
-            child.hide(fabVisibilityChangedListener);
-        } else if (dyConsumed < 0 && child.getVisibility() != View.VISIBLE) {
-            // User scrolled up and the FAB is currently not visible -> show the FAB
-            child.show();
-        }
-    }
-
-    private FloatingActionButton.OnVisibilityChangedListener fabVisibilityChangedListener = new FloatingActionButton.OnVisibilityChangedListener() {
-        @Override
-        public void onHidden(FloatingActionButton fab) {
-            // Starting with support lib 25, hiding the FAB sets its visibility to View.GONE instead of INVISIBLE. This messes up the scrolling
-            // https://stackoverflow.com/questions/41153619/floating-action-button-not-visible-on-scrolling-after-updating-google-support
-            super.onHidden(fab);
-            fab.setVisibility(View.INVISIBLE);
-        }
-    };
-}
diff --git a/app/src/main/res/layout/fragment_conversion.xml b/app/src/main/res/layout/fragment_conversion.xml
index 308a8153..ac39f2b4 100644
--- a/app/src/main/res/layout/fragment_conversion.xml
+++ b/app/src/main/res/layout/fragment_conversion.xml
@@ -41,7 +41,6 @@
 
             <androidx.core.widget.NestedScrollView
                 android:id="@+id/unit_list_container"
-                xmlns:android="http://schemas.android.com/apk/res/android"
                 android:layout_width="match_parent"
                 android:layout_height="match_parent">
 
@@ -80,8 +79,7 @@
                 android:src="@drawable/ic_autorenew_white_24dp"
                 app:backgroundTint="@color/color_accent"
                 app:layout_anchor="@id/unit_list_container"
-                app:layout_anchorGravity="bottom|right|end"
-                app:layout_behavior="com.physphil.android.unitconverterultimate.ui.ScrollAwareFabBehaviour"/>
+                app:layout_anchorGravity="bottom|right|end"/>
 
         </androidx.coordinatorlayout.widget.CoordinatorLayout>