Is this the behaviour we want? is_valid function returns input variable #50
Labels
Discussion
Discussion of a concept or implementation. Need to stay always open.
Enhancement
New feature or request
As I'm working on the unit tests, I've just seen that the
is_valid
function returns the input variable. Doesn't it make more sense for it to be a void function? If the variable is not valid, it could raise an error, but do nothing otherwise.https://github.com/smoia/phys2bids/blob/f2d7d52e4e9d9d963f98aeb8809c81660e2f1794/phys2bids/physio_obj.py#L37
The text was updated successfully, but these errors were encountered: