Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve heuristics rules #45

Open
smoia opened this issue Nov 28, 2019 · 2 comments
Open

Improve heuristics rules #45

smoia opened this issue Nov 28, 2019 · 2 comments
Labels
BrainHack This issue is suggested for BrainHack participants! Enhancement New feature or request Help wanted Extra attention is needed
Milestone
OHBM BrainHack

Comments

@smoia
Copy link
Member

smoia commented Nov 28, 2019 •
edited
Loading

Detailed Description

At the moment, the only thing used during heuristics to get the new filename is the name of the input of phys2bids. It's a very simple, basic way to BIDSify files, but heuristic statements could use much more information than just the name (or instead of the name)! For instance, the number of channels, their content, their lenght, ...

Possible Implementation

  • Have a look at heudiconv and its heuristics
  • Tinker with the heuristics to improve them!
@smoia smoia added the Enhancement New feature or request label Nov 28, 2019
@smoia smoia added Duplicate This issue or pull request already exists and removed Enhancement New feature or request labels Jan 8, 2020
@smoia
Copy link
Member Author

smoia commented Jan 8, 2020

Duplicate of #44

@smoia smoia marked this as a duplicate of #44 Jan 8, 2020
@smoia smoia closed this as completed Jan 8, 2020
@smoia smoia mentioned this issue Mar 12, 2020
Closed
@smoia smoia reopened this Mar 23, 2020
@smoia
Copy link
Member Author

smoia commented Mar 23, 2020

This is not a duplicate of #44 - my bad.
This is about how to improve our heuristic files in order to have prettier and more complex heuristics (à la heudiconv).

It's quite a challenge, if anyone feels inspired/bored enough to tackle this!

@smoia smoia added Enhancement New feature or request Help wanted Extra attention is needed and removed Duplicate This issue or pull request already exists labels Mar 23, 2020
@smoia smoia added the BrainHack This issue is suggested for BrainHack participants! label Apr 5, 2020
@smoia smoia added this to the The BrainWeb milestone Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BrainHack This issue is suggested for BrainHack participants! Enhancement New feature or request Help wanted Extra attention is needed
Projects
None yet
Milestone
OHBM BrainHack
Development

No branches or pull requests
1 participant
@smoia