Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic linting with CI with black #409

Closed
htwangtw opened this issue Jul 8, 2021 · 1 comment
Closed

Automatic linting with CI with black #409

htwangtw opened this issue Jul 8, 2021 · 1 comment

Comments

@htwangtw
Copy link
Contributor

htwangtw commented Jul 8, 2021

Detailed Description

At the July dev call, @smoia mentioned wanting to add linting with CI on PRs for #402

Context / Motivation

We want a more consistent code style, not loading style issue on the project owner, and minimise barriers (ancillary issues such as complex dev environment setup) for new contributors. Everyone wins if there's a lazy linter built into CI.

Possible Implementation

Lint Action supports such a feature. However, it's unclear regarding known conflicts with isort/flake8.
I found another solution using the create-pull-request GitHub action.
This solution is buried at the very end of the guide on market place:
https://github.com/marketplace/actions/run-black-formatter

I am happy to test out and do a PR. Can also check how to integrate isort in the same GitHub action.
Any other style-related stuff you want to add to the GitHub action?

@smoia
Copy link
Member

smoia commented Oct 6, 2023

Just realised this was closed by #445!

@smoia smoia closed this as completed Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants