Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple associated datatypes #247

Open
tsalo opened this issue Jun 16, 2020 · 2 comments
Open

Support multiple associated datatypes #247

tsalo opened this issue Jun 16, 2020 · 2 comments
Labels
Enhancement New feature or request

Comments

@tsalo
Copy link
Member

tsalo commented Jun 16, 2020

Detailed Description

phys2bids currently only convert physio data associated with fMRI (i.e., data under the BIDS func datatype). It would be good to be able to output files in any of the BIDS datatypes that support associated physio data. Currently, I think that's just beh, but I believe that's more of an oversight in the specification than an explicit rule.

Context / Motivation

This will benefit users who want to convert physio data not associated with fMRI data.

Possible Implementation

Perhaps add a field to info in the heuristics file, corresponding to datatype.

@smoia smoia added this to the phys2bids second semester 2020 milestone Jul 30, 2020
@smoia
Copy link
Member

smoia commented Jul 30, 2020

Another possible implementation is to add a flag in the parser (-beh and others) to tell the program to change the destination folder.
Alternatively, we can use different -in flags to indicate the same concept. @tsalo do you know if we can create a parser that has a required [field OR another field]?

@smoia smoia added the Enhancement New feature or request label Jul 30, 2020
@tsalo
Copy link
Member Author

tsalo commented Jul 30, 2020

argparse's add_mutually_exclusive_group() has a required argument, so you could specify that users must provide one of the arguments in the group, but no others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants