Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write docstrings #1

Closed
smoia opened this issue Sep 16, 2019 · 6 comments · Fixed by #80
Closed

Write docstrings #1

smoia opened this issue Sep 16, 2019 · 6 comments · Fixed by #80
Assignees
Labels
Documentation This issue or PR is about the documentation Good first issue Good for newcomers Urgent If you don't know where to start, start here!
Milestone

Comments

@smoia
Copy link
Member

smoia commented Sep 16, 2019

Add numpy docstrings to functions

@smoia smoia added the Documentation This issue or PR is about the documentation label Sep 16, 2019
@smoia smoia added this to the phys2bids public release milestone Sep 16, 2019
@smoia smoia modified the milestones: phys2bids public release, OHBM poster Nov 14, 2019
@smoia smoia mentioned this issue Nov 26, 2019
@smoia smoia added Urgent If you don't know where to start, start here! Good first issue Good for newcomers labels Nov 28, 2019
@smoia
Copy link
Member Author

smoia commented Nov 28, 2019

Most of the scripts we have require docstrings, with the exception of those in heur folder.
Just to be clear, docstrings are a multiline comment at the beginning of each function that briefly explain what the function is doing, and reports Inputs, Outputs and (after @eurunuela 's comment in #38) outcomes (when the function doesn't have a return, but produces something like a file or a print onscreen).
At the moment, physio_obj.py has complete docstrings, phys2bids.py has complete docstrings with the only exception of method main(); utils.py has stubs to complete with info on I/O, viz.py lacks docstrings.

It's a good first issue to start reading the code and fill in the characteristics of the functions. Python knowledge is not necessarily required.

@smoia
Copy link
Member Author

smoia commented Dec 4, 2019

I would still invite someone that would like to start approaching phys2bids code / python3 to complete this issue. Especially in improving utils.py docstrings - most of the functions there are quite trivial, and a valid PR doesn't have to cover everything.
Can I suggest @kristinazvolanek , @RayStick or @AyyagariA for this?
I can help out remotely! Drop me a mesage somewhere if you're interested.

@RayStick
Copy link
Member

RayStick commented Dec 4, 2019

I am happy to help with docstrings once I have used the code a bit more. Personally, I think it is hard to write docstrings if you haven't written or used the code. So at the very least, we need to use the code, if we are not writing it. 


@eurunuela
Copy link
Collaborator

Given that this issue was labeled as urgent, how are we doing with this?

@RayStick
Copy link
Member

It seems that @smoia made good progress on this?

@smoia
Copy link
Member Author

smoia commented Dec 10, 2019

#80 needs a bit more Numpy styling. When that's done this will be closed- but we're near.

@smoia smoia closed this as completed Dec 10, 2019
@smoia smoia reopened this Dec 10, 2019
@RayStick RayStick removed their assignment Jan 8, 2020
@smoia smoia closed this as completed in #80 Jan 27, 2020
eurunuela added a commit that referenced this issue Feb 15, 2020
modifiy test so it doesn't use printing output
smoia referenced this issue in smoia/phys2bids Mar 6, 2020
RayStick pushed a commit that referenced this issue Apr 2, 2020
Overhaul of best practices
smoia pushed a commit that referenced this issue May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation This issue or PR is about the documentation Good first issue Good for newcomers Urgent If you don't know where to start, start here!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants