From 98f5d7f1c8a1b92387c0ebdffc5b665b3db048d5 Mon Sep 17 00:00:00 2001
From: Christian Duerr <chris.durr@phylum.io>
Date: Thu, 28 Apr 2022 22:27:30 +0200
Subject: [PATCH] Allow freely setting project thresholds

Previously the `active` field of the thresholds struct was populated by
checking whether the `threshold` was above `0` or not. However the
`Total Project Threshold` can never be disabled and it is possible for
other thresholds to be at `0` without being disabled too.

To ensure a more accurate representation of the backend state, the
`set_threshold` method instead takes a `Threshold` instance which can be
populated fully by the consumer without any internal restrictions.

See #288.
---
 src/types/user_settings.rs | 17 ++---------------
 1 file changed, 2 insertions(+), 15 deletions(-)

diff --git a/src/types/user_settings.rs b/src/types/user_settings.rs
index dee73f3..919c3ab 100644
--- a/src/types/user_settings.rs
+++ b/src/types/user_settings.rs
@@ -37,13 +37,7 @@ pub struct UserSettings {
 
 impl UserSettings {
     /// Sets the threshold for the given risk domain.
-    pub fn set_threshold(
-        &mut self,
-        project_id: String,
-        name: String,
-        threshold: i32,
-        action: String,
-    ) {
+    pub fn set_threshold(&mut self, project_id: String, name: String, threshold: Threshold) {
         // log::debug!("Retrieving user settings for project: {}", project_id);
         let mut thresholds = self
             .projects
@@ -56,14 +50,7 @@ impl UserSettings {
             });
 
         if let Setting::Project(ref mut t) = thresholds {
-            t.thresholds.insert(
-                name,
-                Threshold {
-                    action,
-                    active: (threshold > 0),
-                    threshold: (threshold as f32) / 100.0,
-                },
-            );
+            t.thresholds.insert(name, threshold);
         }
 
         self.projects.insert(project_id, thresholds);