Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update model for storing additional node properties on phylogeny nodes #130

Open
gaurav opened this issue Dec 8, 2018 · 2 comments
Open
Labels
difficulty: hard Will take a while to close (>5 days)

Comments

@gaurav
Copy link
Member

gaurav commented Dec 8, 2018

We currently have a simple system that allows taxonomic units to be listed for named nodes on a phylogeny. Each phylogeny has an additionalNodeProperties dictionary, which maps node labels to dictionaries containing properties like expectedPhyloreferenceNamed and representsTaxonomicUnits. When the JSON-LD file is generated, these properties are copied into the cdao:Node entity having that node label on that phylogeny. phyx.js also uses these taxonomic units to carry out specifier matching.

The expectedPhyloreferenceNamed property is controlled by the "Expected nodes" field in the Curation Tool, which works fairly intuitively. However, the representsTaxonomicUnits property is controlled by clicking on labeled nodes on the phylogeny and choosing "Edit taxonomic units" in the popup menu. There is no comprehensive list of taxonomic units associated with nodes, or the evidence on the basis of which that determination is made. Furthermore, our current system only supports asserting that a node represents one or more taxonomic units; we would like to support additional relationships between taxonomic units as well (#129).

We need to update this model to include:

  • the taxonomic unit represented by the node
  • relationships between this taxonomic and another taxonomic unit, including:
    • the other taxonomic unit
    • the relationship between the two taxonomic units
    • an explanation of the evidence for this relationship
    • citations supporting this relationship
@gaurav gaurav added difficulty: hard Will take a while to close (>5 days) programming only No discussion necessary; just pure programming needed labels Aug 9, 2019
@gaurav gaurav added this to the Klados v1.0 milestone Nov 10, 2021
@gaurav gaurav added discussion needed Discussion is needed before this issue can be closed and removed programming only No discussion necessary; just pure programming needed labels Dec 14, 2021
@gaurav
Copy link
Member Author

gaurav commented Dec 14, 2021

I think this is overly complex for our needs, and can be replaced with a simpler implementation described in #228.

@gaurav
Copy link
Member Author

gaurav commented Nov 2, 2022

We have agreed on the simpler solution mentioned in the previous comment, and so I'll remove this from the Klados v1.0 milestone.

@gaurav gaurav removed discussion needed Discussion is needed before this issue can be closed potentially closeable labels Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: hard Will take a while to close (>5 days)
Projects
None yet
Development

No branches or pull requests

1 participant