Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New name proposal #11

Open
nohponex opened this issue Jun 25, 2017 · 0 comments
Open

New name proposal #11

nohponex opened this issue Jun 25, 2017 · 0 comments
Labels
help wanted
Milestone
1.x

Comments

@nohponex
Copy link
Member

nohponex commented Jun 25, 2017 •
edited
Loading

While we reaching 1.x milestone, it might be a good idea to change the name, since it causes confusion and it's not clear what the library does.

Also it will be good idea classes to review the class names too

  • Filler and fill() method as a general term
  • FillerRepository, is it actually repository or something else ?
  • xValidatorFiller, (ObjectValidatorFiller) should it contain the Validator substring, which is specific to jsonapi/validator class name ?
@nohponex nohponex added this to the 1.x milestone Jun 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
1.x
Development

No branches or pull requests
1 participant
@nohponex