Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency on nikic/php-parser #86

Closed
kayneth opened this issue Mar 1, 2018 · 1 comment · Fixed by #88
Closed

Update dependency on nikic/php-parser #86

kayneth opened this issue Mar 1, 2018 · 1 comment · Fixed by #88

Comments

@kayneth
Copy link

kayneth commented Mar 1, 2018

Hi,

Is it possible to update to 4.0.0 of nikic/php-parser ? Or do you want to support running on PHP >= 5.5 ?

This question because i want to use Constant Expression evaluation.

For now, there's errors on projects where, in form types, we use constants or declare forms as services to add parameters (we're using an array registered in a Yaml array in parameters).
Current FormTypeChoices Visitor doesn't support this kind of behavior as said in #76.

Thank you :)

Edit : Sorry, i didn't see that the 4.0 version of this repository is from 14 hours ago. Ahah.

@Nyholm
Copy link
Member

Nyholm commented Mar 21, 2018

It sounds like we should do some work to support 4.0.

Good idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants