Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported PHP version, automated builds, better tags? #3

Open
mleczakm opened this issue Feb 4, 2018 · 6 comments
Open

Supported PHP version, automated builds, better tags? #3

mleczakm opened this issue Feb 4, 2018 · 6 comments

Comments

@mleczakm
Copy link

mleczakm commented Feb 4, 2018

It is more a question than an issue. Containers on dockerhub looks a bit outdated - maybe it is a good idea to make some automated builds on webhooks? Also supporting more specified tags (with php version - I've tried with updating php version to 7.2 but it is quite complicated) would be nice - many projects require 7.2 php version due to object typehinting.

I may help, but don't want to make something which won't be accepted later :)

@marcj
Copy link
Member

marcj commented Feb 5, 2018

Many require 7.2? Would love to see those stats. However, I agree we could setup automated builds.

@mleczakm
Copy link
Author

mleczakm commented Feb 5, 2018

Well, I didn't meant these are OS projects ;) but ocramius/proxy is very popular package, which is in almost every PHP project I am working on.

I'll try to build some alpine and debian/ubuntu based images and semi-automate them like in official php library (full-auto isn't possible due to tag naming AFAIK).

@cordoval
Copy link
Contributor

cordoval commented Feb 9, 2018

@marcj loce -> lose

what is it with the stats loosing? i think a good project and maintainer should not need to worry about this.
Whoever needs this will find it. It is actually a good approach and i am giving it a shot on production.

About the 7.2 being difficult, i think it is non sense with a pinch of salt. I mean what is the error that you are getting rather?

The image should obviously be alpine, and not ubuntu mainly.

@soullivaneuh
Copy link

php-pm project is very interesting, but indeed, allow multiple PHP version usage (7.2, 7.3) would unlock some usages.

@soullivaneuh
Copy link

Looking at your file:

php7 php7-opcache php7-fpm php7-cgi php7-ctype php7-json php7-dom php7-zip php7-zip php7-gd \

Instead of using alpine and the provided php packages, why not just use the php official images?

With some automation, you could deliver multiple version thanks to this method.

Would you consider a merge request about that?

@andig
Copy link
Contributor

andig commented Jan 23, 2020

I have found the PHP packages to be very complex. If you find a multi-arch working php approach I'd be happy to consider a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants