Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkstyle severity level is incorrect #67

Open
Spreeuw opened this issue Aug 23, 2021 · 0 comments · May be fixed by #68
Open

Checkstyle severity level is incorrect #67

Spreeuw opened this issue Aug 23, 2021 · 0 comments · May be fixed by #68
Labels
Type: bug

Comments

@Spreeuw
Copy link

Spreeuw commented Aug 23, 2021

in the CheckStyleOutput class, the severity is set to ERROR:

PHP-Parallel-Lint/src/Output.php

Line 442 in 02a09f1

' <error line="%d" severity="ERROR" message="%s" source="%s" />',

Following the Checkstyle specification, allowed values are: ignore, info, warning, error, all lowercase.

When using cs2pr to annotate files in github, this results in the annotations showing as warning (default) instead.

I think it would actually make sense to use warning for deprecation notices.
@Spreeuw Spreeuw linked a pull request Aug 23, 2021 that will close this issue
Open
@jrfnl jrfnl added the Type: bug label Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add error severity levels Spreeuw/PHP-Parallel-Lint
2 participants
@jrfnl @Spreeuw