Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host header rewrite #12

Open
mulfvik opened this issue Apr 21, 2020 · 2 comments
Open

Host header rewrite #12

mulfvik opened this issue Apr 21, 2020 · 2 comments

Comments

@mulfvik
Copy link

mulfvik commented Apr 21, 2020

I get a Invalid Host header on start which is resolved by rewriting the header. It would be nice if this could be done from this extension. Here is an example
ngrok http --host-header=rewrite 8080

@philnash
Copy link
Owner

Thanks for opening an issue!

This is a good idea. You can set the host_header against a tunnel definition in your ngrok config and my initial thought was that all settings should be handled through config like that.

However, I've definitely used host header on one off tunnels.

I wonder what interface would be good for this. We could add a config option in the VSCode config for host header that gets applied to one off tunnels (but not named tunnels).

I think I want to keep the start command as simple as possible. It wouldn't be a good experience for it to ask a bunch of config questions each time you try to open a tunnel.

As an extension, what do you think about a command that opens the ngrok config in the current editor?

@mulfvik
Copy link
Author

mulfvik commented Apr 22, 2020

It could be nice to be able to set an default host header in VSCode, then one can use it per workspace aswell. But to have all configuration in one place and the plugin just serves that with a command feels intuitive.
I guess it depends on how usual this Invalid Host header is over all. This plugin is my entry to ngrok so I cant answer that one :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants