Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest amplitude control changes #71

Open
KatieWoe opened this issue Nov 1, 2021 · 2 comments
Open

Suggest amplitude control changes #71

KatieWoe opened this issue Nov 1, 2021 · 2 comments

Comments

@KatieWoe
Copy link
Contributor

KatieWoe commented Nov 1, 2021

Test device
Dell
Operating System
Win 11
Browser
Chrome
Problem description
For phetsims/qa#724. These are less bugs, and more changes that may be good to consider. On the 1D screen, the y axis has a much smaller range of amplitude you can drag the points than the x-axis. On the 2D screen, while you can have partial amplitudes by dragging the points, you can only get min or max levels when using the amplitude sensors on the right. In the 1D screen you could control these amplitudes with a slider.

Visuals
partial2d
bigsideamplitude

Troubleshooting information:

!!!!! DO NOT EDIT !!!!!
Name: ‪Normal Modes‬
URL: https://phet-dev.colorado.edu/html/normal-modes/1.0.0-dev.5/phet/normal-modes_en_phet.html
Version: 1.0.0-dev.5 2021-11-01 21:43:06 UTC
Features missing: applicationcache, applicationcache, touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/95.0.4638.54 Safari/537.36
Language: en-US
Window: 1280x649
Pixel Ratio: 1.5/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {}

@KatieWoe KatieWoe added type:bug Something isn't working type:suggestion labels Nov 1, 2021
@pixelzoom
Copy link
Contributor

pixelzoom commented Nov 2, 2021

In #67, @ariel-phet requested the reduced ranges for the ampitude sliders in the 'One Dimension' screen. So I'll let him respond to this issue.

@pixelzoom pixelzoom assigned ariel-phet and unassigned pixelzoom Nov 2, 2021
@ariel-phet
Copy link

@KatieWoe -- in a published version we will want to restrict the x -axis dragging on the 1-d screen, but this would be a complicated change for the prototype so we punted for the moment.

On the 2-d screen we should tweak several things (including your suggestion of amplitude readouts/maxes) but again, this was deemed too much effort for the prototype.

@ariel-phet ariel-phet removed their assignment Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants