Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change requests #57

Open
pixelzoom opened this issue Sep 17, 2020 · 7 comments
Open

change requests #57

pixelzoom opened this issue Sep 17, 2020 · 7 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Sep 17, 2020

@ariel-phet and I started putting together a list of potential change requests. Some of these may eventually be promoted to their own GitHub issues.

  • use standard TimeControlNode, Replace "Speed" control with TimeControlNode #58
  • put constraints on stretching, so we don't get so much motion outside the layoutBounds (or visibleBounds?)
  • see the full waveform in Normal Modes accordion box
  • in horizontal mode, make the springs look like the Flash version (sawtooth)
  • in vertical mode, either make springs look like they do now (preferred), or like horizontal mode -- whatever is easiest
  • in 2nd screen, like the look of the springs now, sawtooth look would be too noisy
  • title on “Normal Mode Amplitudes” accordion box should be visible when open, Show title when the "Normal Mode Amplitudes" accordion box is expanded #59
  • label cells in “Normal Mode Amplitudes” accordion box like the Flash version -- (1,1) (1,2) ...

... to be continued.

@pixelzoom
Copy link
Contributor Author

@ariel-phet anything to add to this issue?

@ariel-phet
Copy link

Some more thoughts:

  1. A possibility might be to just have the thickness of the lines connecting masses correspond to their stretch. More like elastic bands (thin when stretched, thicker when compressed). I would think this would be simpler programmatically since the line width could just be a function of its length compared to its "rest" length. Such an approach would give a consistent look on all screens/situations, would likely not be too visually distracting.

  2. To clarify above, the constraint on stretching probably just needs to be in terms of how far a user can stretch any given mass in terms of an excursion from its equilibrium.

  3. On the second screen, the "Normal Modes Amplitudes" display needs some work, which might be suitable for a short design meeting or two. In terms of goals:

  • It should be clear that the display is also a control (so clicking one of the cells excites that mode), right now this is not particularly obvious.
  • The original sim had the horizontal and vertical modes as "tabs" of the panel. Well not perfect, that way of conveying the information gave more of the impression that both horizontal and vertical modes could be present
  • perhaps a possibility would be to have a radio button group that puts you in "display" or "control" mode. And in control mode these are obvious buttons. I am not sure, but this panel/accordion box does convey lots of interesting information and allow interesting control, so it would be ideal to present better

@ariel-phet ariel-phet assigned pixelzoom and issamali67 and unassigned ariel-phet Jan 26, 2021
@ariel-phet
Copy link

@issamali67 when you begin working on this sim in earnest, it would be good to request some design meeting time and get input on the suggested changes/enhancements

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jan 28, 2021

@issamali67 The designer for this sim hasn't been determined yet, but according to @arouinfar, it will likely be either @arouinfar or @DianaTavares.

@pixelzoom pixelzoom removed their assignment Feb 1, 2021
@pixelzoom
Copy link
Contributor Author

@issamali67: @DianaTavares is your lead designer, see #61 (comment). Please communicate with her on design questions. And if you need any support, let me know.

@pixelzoom
Copy link
Contributor Author

4/8/21 Q2 planning meeting:

@kathy-phet mentioned that @DianaTavares has completed design. At some point, the design and implementation should be compared, to generate any additional "change requests". Those can either be listed in this issue, or new issues can be created.

@DianaTavares
Copy link

DianaTavares commented Apr 14, 2021

I did the comparison between the Mockup and the implementation that this is all the differences about the design:

  • the masses in the first screen need to have rounded corners.
    image

  • The springs that join the masses in the first screen need to have a zig-zag shape, with a behavior similar to the flash sim, where the stroke change depending on the number of masses and the movement of the masses.

image

  • the drag movement of the masses is restringed. They can not be dragged outside the play area and beyond the position of another mass. This happens on both screens. When a user clicks or taps a mass, a dotted rectangle going to show the limited area where the mass can be dragged.
    image

  • when the screens open for the first time, yellow clue arrows are going to be displayed close to the masses. the arrows disappear once that the user moves one mass.
    image

  • The size and distribution of the components in the controls panel are different. Look at the picture to look at the new distribution and the position of the checkboxes "Show Springs" and "Show phases"
    image

  • In the implementation, the Normal Mode spectrum panel moves up when the "Show phase" is active. In the Mockup, the control has a fixed position and when the "Show phase" is active the phases are displayed at the bottom, making the panel bigger. This also allows that the play area is fix, and a rectangle delimits the play area.
    image

  • The screens icons
    image

  • also the position, size, and organization of the control panels in the second screen.
    image

  • The "Normal Mode Spectrum" panel in the second screen needs several changes, one is the name of the panel and to include the "Normal Numbers r,s" labels. The behavior of the r,s labels in the matrix is the same that the flash sim (the size of the font change to fit inside the squares in the matrix)
    image

image

  • The squares in the matrix need to look more like buttons
    image

  • The orientation of the horizontal normal mode amplitudes should be horizontal, and the color is different for colorblindness reasons:
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants