Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magic numbers #38

Open
pixelzoom opened this issue Feb 10, 2020 · 0 comments
Open

magic numbers #38

pixelzoom opened this issue Feb 10, 2020 · 0 comments
Labels
dev:code-review

Comments

@pixelzoom
Copy link
Contributor

Related to #2 (code review):

  • Are there any magic numbers that should be factored out as constants and documented?

There are a couple of TODO comments that contain "magic number", they should be reviewed. It's likely they can just be documented and promoted to constants (either in the .js file or in NormalModesConstants.js).
@pixelzoom pixelzoom mentioned this issue Feb 10, 2020
Closed
pixelzoom added a commit that referenced this issue Sep 17, 2020
@pixelzoom
TODOs for magic numbers, #38
6f50c28
@pixelzoom pixelzoom changed the title magic numbers? magic numbers Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pixelzoom