Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sim fails stringTest #10

Open
pixelzoom opened this issue Feb 8, 2020 · 0 comments
Open

sim fails stringTest #10

pixelzoom opened this issue Feb 8, 2020 · 0 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 8, 2020

Related to #2 (code review).

The sim currently fails these stringTest checklist items in the code review:

  • Does the sim layout gracefully handle internationalized strings that are twice as long as the English strings? (run with query parameter stringTest=double)

  • Does the sim layout gracefully handle internationalized strings that are exceptionally long? (run with query parameter stringTest=long)

E.g. with ?stringTest=long:

screenshot_106

This checklist item is also questionable:

  • Are there any strings that are not internationalized, and does the sim layout gracefully handle internationalized strings that are shorter than the English strings? (run with query parameter stringTest=X. You should see nothing but 'X' strings.)

The omega symbol ω is not translatable (see AmpPhaseAccordionBox line 166). Should it be? E.g. with ?stringTest=X:

screenshot_107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant