From f525cf6d6285ebc8591b56cb633ed63811333a60 Mon Sep 17 00:00:00 2001 From: Koen De Hondt Date: Sun, 21 Jan 2024 12:29:14 +0100 Subject: [PATCH 01/11] Set the minWidth and the minHeight of the endPanel created for a box layout, so that an empty endPanel does not render the default number of pixels specified in Morph>>#minWidth and Morph>>#minHeight. --- src/Spec2-Adapters-Morphic/SpMorphicBoxAdapter.class.st | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/Spec2-Adapters-Morphic/SpMorphicBoxAdapter.class.st b/src/Spec2-Adapters-Morphic/SpMorphicBoxAdapter.class.st index 25bfbae4d..4229c144f 100644 --- a/src/Spec2-Adapters-Morphic/SpMorphicBoxAdapter.class.st +++ b/src/Spec2-Adapters-Morphic/SpMorphicBoxAdapter.class.st @@ -212,6 +212,7 @@ SpMorphicBoxAdapter >> newHorizontal [ listDirection: #leftToRight; hResizing: #shrinkWrap; width: 0; + minWidth: 0; "Otherwise an empty endPanel has a width of 2 pixels due to Morph>>#minWidth." yourself); yourself ] @@ -236,6 +237,7 @@ SpMorphicBoxAdapter >> newVertical [ listDirection: #topToBottom; vResizing: #shrinkWrap; height: 0; + minHeight: 0; "Otherwise an empty endPanel has a height of 2 pixels due to Morph>>#minHeight." yourself); yourself ] From bb858f6332e166b53a823d88f9b6267f7bf6264f Mon Sep 17 00:00:00 2001 From: Koen De Hondt Date: Fri, 26 Jan 2024 14:48:25 +0100 Subject: [PATCH 02/11] Adapt two SpMorphicBoxLayoutTest tests to ensure that rounding errors for the width of presenters do not make the test fail. Also use the same style of writing the assertions in the two tests. --- .../SpMorphicBoxLayoutTest.class.st | 42 +++++++++++-------- 1 file changed, 24 insertions(+), 18 deletions(-) diff --git a/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st b/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st index ea834b069..b6df864b0 100644 --- a/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st +++ b/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st @@ -111,13 +111,15 @@ SpMorphicBoxLayoutTest >> testBeHomogeneousWorksWhenContractingWindow [ p2 label: 'Label'. p3 items: #( one two three ). - [ + [ presenter open. backend waitUntilUIRedrawed. - presenter withWindowDo: [ :window | - window adapter widgetDo: [ :widget | - widget extent: widget extent - (50 @ 50) ] ]. - backend waitUntilUIRedrawed ] ensure: [ + presenter withWindowDo: [ :window | + window adapter widgetDo: [ :widget | + "Make the presenter's width a multiple of 3, + so that there are no rounding differences in the width of the nested presenters." + widget extent: widget extent - (45 @ 50) ] ]. + backend waitUntilUIRedrawed ] ensure: [ presenter withWindowDo: #close ]. windowWidth := presenter window adapter widget width. @@ -134,7 +136,7 @@ SpMorphicBoxLayoutTest >> testBeHomogeneousWorksWhenContractingWindow [ { #category : #tests } SpMorphicBoxLayoutTest >> testBeHomogeneousWorksWhenExpandingWindow [ - | presenter p1 p2 p3 | + | presenter p1 p2 p3 windowWidth presenterWidth width1 width2 width3 | presenter := SpPresenter new. presenter layout: (SpBoxLayout newHorizontal beHomogeneous; @@ -147,22 +149,26 @@ SpMorphicBoxLayoutTest >> testBeHomogeneousWorksWhenExpandingWindow [ p2 label: 'Label'. p3 items: #( one two three ). - [ + [ presenter open. backend waitUntilUIRedrawed. - presenter withWindowDo: [ :window | - window adapter widgetDo: [ :widget | - widget extent: widget extent + (200 @ 10) ] ]. - backend waitUntilUIRedrawed ] ensure: [ + presenter withWindowDo: [ :window | + window adapter widgetDo: [ :widget | + "Make the presenter's width a multiple of 3, + so that there are no rounding differences in the width of the nested presenters." + widget extent: widget extent + (210 @ 10) ] ]. + backend waitUntilUIRedrawed ] ensure: [ presenter withWindowDo: #close ]. - self assert: presenter adapter widget width - >= (p1 adapter widget width + p2 adapter widget width - + p3 adapter widget width). - self assert: p2 adapter widget width equals: p3 adapter widget width. - self assert: p1 adapter widget width equals: p2 adapter widget width. - self assert: presenter window adapter widget width - >= presenter adapter widget width + windowWidth := presenter window adapter widget width. + presenterWidth := presenter adapter widget width. + width1 := p1 adapter widget width. + width2 := p2 adapter widget width. + width3 := p3 adapter widget width. + self assert: presenterWidth >= (width1 + width2 + width3). + self assert: width1 equals: width2. + self assert: width2 equals: width3. + self assert: windowWidth >= presenterWidth ] { #category : #tests } From 377b41d8a6611133e04dcdd4fc68a9206bc07d6b Mon Sep 17 00:00:00 2001 From: Koen De Hondt Date: Fri, 26 Jan 2024 15:07:39 +0100 Subject: [PATCH 03/11] Assert initial window width to ensure correctness of asserts that follow. --- .../SpMorphicBoxLayoutTest.class.st | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st b/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st index b6df864b0..a7b5e161a 100644 --- a/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st +++ b/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st @@ -95,7 +95,7 @@ SpMorphicBoxLayoutTest >> testBeHomogeneous [ { #category : #tests } SpMorphicBoxLayoutTest >> testBeHomogeneousWorksWhenContractingWindow [ - | presenter p1 p2 p3 windowWidth presenterWidth width1 width2 width3 | + | presenter p1 p2 p3 windowWidth presenterWidth width1 width2 width3 initialWindowWidth | "not working on CI :(" self skipOnPharoCITestingEnvironment. @@ -114,6 +114,8 @@ SpMorphicBoxLayoutTest >> testBeHomogeneousWorksWhenContractingWindow [ [ presenter open. backend waitUntilUIRedrawed. + initialWindowWidth := presenter window adapter widget width. + self assert: initialWindowWidth equals: 400. presenter withWindowDo: [ :window | window adapter widgetDo: [ :widget | "Make the presenter's width a multiple of 3, @@ -136,7 +138,7 @@ SpMorphicBoxLayoutTest >> testBeHomogeneousWorksWhenContractingWindow [ { #category : #tests } SpMorphicBoxLayoutTest >> testBeHomogeneousWorksWhenExpandingWindow [ - | presenter p1 p2 p3 windowWidth presenterWidth width1 width2 width3 | + | presenter p1 p2 p3 windowWidth presenterWidth width1 width2 width3 initialWindowWidth | presenter := SpPresenter new. presenter layout: (SpBoxLayout newHorizontal beHomogeneous; @@ -152,6 +154,8 @@ SpMorphicBoxLayoutTest >> testBeHomogeneousWorksWhenExpandingWindow [ [ presenter open. backend waitUntilUIRedrawed. + initialWindowWidth := presenter window adapter widget width. + self assert: initialWindowWidth equals: 400. presenter withWindowDo: [ :window | window adapter widgetDo: [ :widget | "Make the presenter's width a multiple of 3, From b1c3c1aebabd5f77edd6332ca07e1a8902a8649e Mon Sep 17 00:00:00 2001 From: Koen De Hondt Date: Fri, 26 Jan 2024 15:17:13 +0100 Subject: [PATCH 04/11] Set initial extent to window. --- .../SpMorphicBoxLayoutTest.class.st | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st b/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st index a7b5e161a..28844fef4 100644 --- a/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st +++ b/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st @@ -112,7 +112,7 @@ SpMorphicBoxLayoutTest >> testBeHomogeneousWorksWhenContractingWindow [ p3 items: #( one two three ). [ - presenter open. + presenter asWindow initialExtent: 400 @ 150; open. backend waitUntilUIRedrawed. initialWindowWidth := presenter window adapter widget width. self assert: initialWindowWidth equals: 400. @@ -152,7 +152,7 @@ SpMorphicBoxLayoutTest >> testBeHomogeneousWorksWhenExpandingWindow [ p3 items: #( one two three ). [ - presenter open. + presenter asWindow initialExtent: 400 @ 150; open. backend waitUntilUIRedrawed. initialWindowWidth := presenter window adapter widget width. self assert: initialWindowWidth equals: 400. From a313dee7d13072c8fc2d008867b3a62d1d7fbf45 Mon Sep 17 00:00:00 2001 From: Koen De Hondt Date: Fri, 26 Jan 2024 15:29:24 +0100 Subject: [PATCH 05/11] Do not make the window bigger than 600 --- src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st b/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st index 28844fef4..7de62b0b4 100644 --- a/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st +++ b/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st @@ -160,7 +160,7 @@ SpMorphicBoxLayoutTest >> testBeHomogeneousWorksWhenExpandingWindow [ window adapter widgetDo: [ :widget | "Make the presenter's width a multiple of 3, so that there are no rounding differences in the width of the nested presenters." - widget extent: widget extent + (210 @ 10) ] ]. + widget extent: widget extent + (60 @ 10) ] ]. backend waitUntilUIRedrawed ] ensure: [ presenter withWindowDo: #close ]. From 0a094d4b37b763395e5a1005c204b2162be9a3e9 Mon Sep 17 00:00:00 2001 From: Koen De Hondt Date: Fri, 26 Jan 2024 15:37:11 +0100 Subject: [PATCH 06/11] Remove unnecessary asserts and #initialExtent: that has no effect on CI. --- .../SpMorphicBoxLayoutTest.class.st | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st b/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st index 7de62b0b4..846d0590e 100644 --- a/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st +++ b/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st @@ -112,10 +112,9 @@ SpMorphicBoxLayoutTest >> testBeHomogeneousWorksWhenContractingWindow [ p3 items: #( one two three ). [ - presenter asWindow initialExtent: 400 @ 150; open. + presenter open. backend waitUntilUIRedrawed. initialWindowWidth := presenter window adapter widget width. - self assert: initialWindowWidth equals: 400. presenter withWindowDo: [ :window | window adapter widgetDo: [ :widget | "Make the presenter's width a multiple of 3, @@ -152,10 +151,9 @@ SpMorphicBoxLayoutTest >> testBeHomogeneousWorksWhenExpandingWindow [ p3 items: #( one two three ). [ - presenter asWindow initialExtent: 400 @ 150; open. + presenter open. backend waitUntilUIRedrawed. initialWindowWidth := presenter window adapter widget width. - self assert: initialWindowWidth equals: 400. presenter withWindowDo: [ :window | window adapter widgetDo: [ :widget | "Make the presenter's width a multiple of 3, From 1b57c60ae743c707ce1bb57dfff876c7a6692441 Mon Sep 17 00:00:00 2001 From: Koen De Hondt Date: Fri, 26 Jan 2024 16:02:09 +0100 Subject: [PATCH 07/11] Use better assertions --- .../SpMorphicBoxLayoutTest.class.st | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st b/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st index 846d0590e..074925750 100644 --- a/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st +++ b/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st @@ -86,7 +86,7 @@ SpMorphicBoxLayoutTest >> testBeHomogeneous [ presenter withWindowDo: #close ]. self assert: presenter adapter widget width - >= (p1 adapter widget width + p2 adapter widget width + equals: (p1 adapter widget width + p2 adapter widget width + p3 adapter widget width). self assert: p2 adapter widget width equals: p3 adapter widget width. self assert: p1 adapter widget width equals: p2 adapter widget width @@ -128,7 +128,7 @@ SpMorphicBoxLayoutTest >> testBeHomogeneousWorksWhenContractingWindow [ width1 := p1 adapter widget width. width2 := p2 adapter widget width. width3 := p3 adapter widget width. - self assert: presenterWidth >= (width1 + width2 + width3). + self assert: presenterWidth equals: (width1 + width2 + width3). self assert: width1 equals: width2. self assert: width2 equals: width3. self assert: windowWidth >= presenterWidth @@ -167,7 +167,7 @@ SpMorphicBoxLayoutTest >> testBeHomogeneousWorksWhenExpandingWindow [ width1 := p1 adapter widget width. width2 := p2 adapter widget width. width3 := p3 adapter widget width. - self assert: presenterWidth >= (width1 + width2 + width3). + self assert: presenterWidth equals: (width1 + width2 + width3). self assert: width1 equals: width2. self assert: width2 equals: width3. self assert: windowWidth >= presenterWidth From 3347b624d6a1c543078cb73393db19f5d023ad9c Mon Sep 17 00:00:00 2001 From: Koen De Hondt Date: Fri, 26 Jan 2024 16:25:39 +0100 Subject: [PATCH 08/11] Use a button instead of a list in the box layout --- .../SpMorphicBoxLayoutTest.class.st | 36 ++++++++++--------- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st b/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st index 074925750..83a349050 100644 --- a/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st +++ b/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st @@ -64,7 +64,7 @@ SpMorphicBoxLayoutTest >> testAddWithPaddingVertical [ { #category : #tests } SpMorphicBoxLayoutTest >> testBeHomogeneous [ - | presenter p1 p2 p3 | + | presenter p1 p2 p3 presenterWidth width1 width2 width3 | "not working on CI :(" self skipOnPharoCITestingEnvironment. @@ -73,23 +73,25 @@ SpMorphicBoxLayoutTest >> testBeHomogeneous [ beHomogeneous; add: (p1 := presenter newButton); add: (p2 := presenter newLabel); - add: (p3 := presenter newList); + add: (p3 := presenter newButton); yourself). p1 label: 'Button'. p2 label: 'Label'. - p3 items: #( one two three ). + p3 label: 'Button'. - [ - presenter open. - backend waitUntilUIRedrawed ] ensure: [ + [ + presenter asWindow initialExtent: 190@150; open. + backend waitUntilUIRedrawed ] ensure: [ presenter withWindowDo: #close ]. - self assert: presenter adapter widget width - equals: (p1 adapter widget width + p2 adapter widget width - + p3 adapter widget width). - self assert: p2 adapter widget width equals: p3 adapter widget width. - self assert: p1 adapter widget width equals: p2 adapter widget width + presenterWidth := presenter adapter widget width. + width1 := p1 adapter widget width. + width2 := p2 adapter widget width. + width3 := p3 adapter widget width. + self assert: presenterWidth equals: (width1 + width2 + width3). + self assert: width1 equals: width2. + self assert: width2 equals: width3 ] { #category : #tests } @@ -104,22 +106,22 @@ SpMorphicBoxLayoutTest >> testBeHomogeneousWorksWhenContractingWindow [ beHomogeneous; add: (p1 := presenter newButton); add: (p2 := presenter newLabel); - add: (p3 := presenter newList); + add: (p3 := presenter newButton); yourself). p1 label: 'Button'. p2 label: 'Label'. - p3 items: #( one two three ). + p3 label: 'Button'. [ - presenter open. + presenter asWindow initialExtent: 190@150; open. backend waitUntilUIRedrawed. initialWindowWidth := presenter window adapter widget width. presenter withWindowDo: [ :window | window adapter widgetDo: [ :widget | "Make the presenter's width a multiple of 3, so that there are no rounding differences in the width of the nested presenters." - widget extent: widget extent - (45 @ 50) ] ]. + widget extent: widget extent - (30 @ 50) ] ]. backend waitUntilUIRedrawed ] ensure: [ presenter withWindowDo: #close ]. @@ -143,12 +145,12 @@ SpMorphicBoxLayoutTest >> testBeHomogeneousWorksWhenExpandingWindow [ beHomogeneous; add: (p1 := presenter newButton); add: (p2 := presenter newLabel); - add: (p3 := presenter newList); + add: (p3 := presenter newButton); yourself). p1 label: 'Button'. p2 label: 'Label'. - p3 items: #( one two three ). + p3 label: 'Button'. [ presenter open. From 9512fe73b6ab16efd9ca10afda658694518bd7ec Mon Sep 17 00:00:00 2001 From: Koen De Hondt Date: Fri, 26 Jan 2024 16:30:27 +0100 Subject: [PATCH 09/11] Use fixed initial window extent --- .../SpMorphicBoxLayoutTest.class.st | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st b/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st index 83a349050..84ff1cba2 100644 --- a/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st +++ b/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st @@ -153,14 +153,14 @@ SpMorphicBoxLayoutTest >> testBeHomogeneousWorksWhenExpandingWindow [ p3 label: 'Button'. [ - presenter open. + presenter asWindow initialExtent: 190@150; open. backend waitUntilUIRedrawed. initialWindowWidth := presenter window adapter widget width. presenter withWindowDo: [ :window | window adapter widgetDo: [ :widget | "Make the presenter's width a multiple of 3, so that there are no rounding differences in the width of the nested presenters." - widget extent: widget extent + (60 @ 10) ] ]. + widget extent: widget extent + (30 @ 10) ] ]. backend waitUntilUIRedrawed ] ensure: [ presenter withWindowDo: #close ]. From fc3c757bad7325142f2f9acc1a85d4eaac1348ac Mon Sep 17 00:00:00 2001 From: Koen De Hondt Date: Fri, 26 Jan 2024 16:35:31 +0100 Subject: [PATCH 10/11] Remove #skipOnPharoCITestingEnvironment from tests and add comment --- .../SpMorphicBoxLayoutTest.class.st | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st b/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st index 84ff1cba2..cff68e4e5 100644 --- a/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st +++ b/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st @@ -65,9 +65,6 @@ SpMorphicBoxLayoutTest >> testAddWithPaddingVertical [ SpMorphicBoxLayoutTest >> testBeHomogeneous [ | presenter p1 p2 p3 presenterWidth width1 width2 width3 | - "not working on CI :(" - self skipOnPharoCITestingEnvironment. - presenter := SpPresenter new. presenter layout: (SpBoxLayout newHorizontal beHomogeneous; @@ -81,6 +78,7 @@ SpMorphicBoxLayoutTest >> testBeHomogeneous [ p3 label: 'Button'. [ + "190 = 5 window border + 180 + 5 window border. 180 is a multiple of 3 (all presenters have the same width)." presenter asWindow initialExtent: 190@150; open. backend waitUntilUIRedrawed ] ensure: [ presenter withWindowDo: #close ]. @@ -98,9 +96,6 @@ SpMorphicBoxLayoutTest >> testBeHomogeneous [ SpMorphicBoxLayoutTest >> testBeHomogeneousWorksWhenContractingWindow [ | presenter p1 p2 p3 windowWidth presenterWidth width1 width2 width3 initialWindowWidth | - "not working on CI :(" - self skipOnPharoCITestingEnvironment. - presenter := SpPresenter new. presenter layout: (SpBoxLayout newHorizontal beHomogeneous; @@ -114,12 +109,13 @@ SpMorphicBoxLayoutTest >> testBeHomogeneousWorksWhenContractingWindow [ p3 label: 'Button'. [ + "190 = 5 window border + 180 + 5 window border. 180 is a multiple of 3 (all presenters have the same width)." presenter asWindow initialExtent: 190@150; open. backend waitUntilUIRedrawed. initialWindowWidth := presenter window adapter widget width. presenter withWindowDo: [ :window | window adapter widgetDo: [ :widget | - "Make the presenter's width a multiple of 3, + "Keep the presenter's width a multiple of 3, so that there are no rounding differences in the width of the nested presenters." widget extent: widget extent - (30 @ 50) ] ]. backend waitUntilUIRedrawed ] ensure: [ @@ -153,12 +149,13 @@ SpMorphicBoxLayoutTest >> testBeHomogeneousWorksWhenExpandingWindow [ p3 label: 'Button'. [ + "190 = 5 window border + 180 + 5 window border. 180 is a multiple of 3 (all presenters have the same width)." presenter asWindow initialExtent: 190@150; open. backend waitUntilUIRedrawed. initialWindowWidth := presenter window adapter widget width. presenter withWindowDo: [ :window | window adapter widgetDo: [ :widget | - "Make the presenter's width a multiple of 3, + "Keep the presenter's width a multiple of 3, so that there are no rounding differences in the width of the nested presenters." widget extent: widget extent + (30 @ 10) ] ]. backend waitUntilUIRedrawed ] ensure: [ From b7a44d5f24b539ef8eac08ea539a9f85a78a3b4c Mon Sep 17 00:00:00 2001 From: Koen De Hondt Date: Fri, 26 Jan 2024 16:43:09 +0100 Subject: [PATCH 11/11] Use stricter assertions --- .../SpMorphicBoxLayoutTest.class.st | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st b/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st index cff68e4e5..fd1b17365 100644 --- a/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st +++ b/src/Spec2-Morphic-Backend-Tests/SpMorphicBoxLayoutTest.class.st @@ -129,7 +129,7 @@ SpMorphicBoxLayoutTest >> testBeHomogeneousWorksWhenContractingWindow [ self assert: presenterWidth equals: (width1 + width2 + width3). self assert: width1 equals: width2. self assert: width2 equals: width3. - self assert: windowWidth >= presenterWidth + self assert: windowWidth equals: presenterWidth + 10 "5 + 5 of the window borders" ] { #category : #tests } @@ -169,7 +169,7 @@ SpMorphicBoxLayoutTest >> testBeHomogeneousWorksWhenExpandingWindow [ self assert: presenterWidth equals: (width1 + width2 + width3). self assert: width1 equals: width2. self assert: width2 equals: width3. - self assert: windowWidth >= presenterWidth + self assert: windowWidth equals: presenterWidth + 10 "5 + 5 of the window borders" ] { #category : #tests }