Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StDebuggerSettings class(Object)>>doesNotUnderstand: #initializeWindow: #958

Open
Ducasse opened this issue Jan 25, 2025 · 3 comments
Open

Comments

@Ducasse
Copy link
Contributor

Ducasse commented Jan 25, 2025

StDebuggerSettings class(Object)>>doesNotUnderstand: #initializeWindow:
StDebuggerSettings class>>initializeWindow:
StDebugger>>initializeWindow:

this leads to an infinite loops.

@StevenCostiou
Copy link
Member

That code is working for me in build 406.
Something has changed since then.

However that implementation was planned to be changed or removed.

@StevenCostiou
Copy link
Member

There, commit 5cf020f
StDebuggerSetting is not a spec presenter but a class supposed to handle settings for the debugger.
So it cannot call super initializeWindow:

This method should not be named like that anyway.
This class is going to be heavily changed soon anyway.

Image

@StevenCostiou
Copy link
Member

=> the fix should be two-fold:

  • rename the method to something with "setting" inside
  • remove the super call

I cannot do it until monday, but the fix is simple

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants