From b3da21d8b49504ad7989a827917f090c2a17a59f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?St=C3=A9phaneDucasse?= Date: Sun, 26 Jan 2025 11:12:34 +0100 Subject: [PATCH 1/2] Fixing StRewriter --- .../StRewriterAbstractToolTest.class.st | 6 ------ .../StRewriterOccurrencesBrowserPresenterTest.class.st | 2 +- .../StRewriterExpressionFinderPresenter.class.st | 6 ------ .../StRewriterRuleLoaderPresenter.class.st | 6 ------ 4 files changed, 1 insertion(+), 19 deletions(-) diff --git a/src/NewTools-RewriterTools-Tests/StRewriterAbstractToolTest.class.st b/src/NewTools-RewriterTools-Tests/StRewriterAbstractToolTest.class.st index 19b1a098f..bb8cb3062 100644 --- a/src/NewTools-RewriterTools-Tests/StRewriterAbstractToolTest.class.st +++ b/src/NewTools-RewriterTools-Tests/StRewriterAbstractToolTest.class.st @@ -31,12 +31,6 @@ StRewriterAbstractToolTest >> testIconName [ self assert: self toolClass iconName isSymbol ] -{ #category : 'tests' } -StRewriterAbstractToolTest >> testTitle [ - - self deny: self toolClass title equals: 'Untitled window' -] - { #category : 'accessing' } StRewriterAbstractToolTest >> toolClass [ diff --git a/src/NewTools-RewriterTools-Tests/StRewriterOccurrencesBrowserPresenterTest.class.st b/src/NewTools-RewriterTools-Tests/StRewriterOccurrencesBrowserPresenterTest.class.st index 73d28d4c3..0ab56c97f 100644 --- a/src/NewTools-RewriterTools-Tests/StRewriterOccurrencesBrowserPresenterTest.class.st +++ b/src/NewTools-RewriterTools-Tests/StRewriterOccurrencesBrowserPresenterTest.class.st @@ -30,5 +30,5 @@ StRewriterOccurrencesBrowserPresenterTest >> testCritiques [ { #category : 'tests' } StRewriterOccurrencesBrowserPresenterTest >> testTitle [ - self deny: StRewriterOccurrencesBrowserPresenter title equals: 'Untitled window' + self assert: StRewriterOccurrencesBrowserPresenter new windowTitle equals: 'Occurrences matches' ] diff --git a/src/NewTools-RewriterTools/StRewriterExpressionFinderPresenter.class.st b/src/NewTools-RewriterTools/StRewriterExpressionFinderPresenter.class.st index 0a5894e20..a8e38ac9f 100644 --- a/src/NewTools-RewriterTools/StRewriterExpressionFinderPresenter.class.st +++ b/src/NewTools-RewriterTools/StRewriterExpressionFinderPresenter.class.st @@ -52,12 +52,6 @@ StRewriterExpressionFinderPresenter class >> menuCommandOn: aBuilder [ help: self descriptionText ] -{ #category : 'specs' } -StRewriterExpressionFinderPresenter class >> title [ - - ^ 'Expression Finder' -] - { #category : 'initialization' } StRewriterExpressionFinderPresenter >> connectPresenters [ diff --git a/src/NewTools-RewriterTools/StRewriterRuleLoaderPresenter.class.st b/src/NewTools-RewriterTools/StRewriterRuleLoaderPresenter.class.st index 23225f423..aeef29c38 100644 --- a/src/NewTools-RewriterTools/StRewriterRuleLoaderPresenter.class.st +++ b/src/NewTools-RewriterTools/StRewriterRuleLoaderPresenter.class.st @@ -40,12 +40,6 @@ StRewriterRuleLoaderPresenter class >> iconName [ ^ #smallLoadProject ] -{ #category : 'specs' } -StRewriterRuleLoaderPresenter class >> title [ - - ^ 'Rewrite rule loader' -] - { #category : 'layout' } StRewriterRuleLoaderPresenter >> defaultLayout [ From 20119ca728af0f937165fba5a7669fa24bd12882 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?St=C3=A9phaneDucasse?= Date: Sun, 26 Jan 2025 11:21:22 +0100 Subject: [PATCH 2/2] Fixing superclass duplicated methods --- src/ColorPicker/SpColorCodePresenter.class.st | 6 ------ src/NewTools-MethodBrowsers/StMessageBrowser.class.st | 6 ------ .../StPlaygroundBindingsPresenter.class.st | 6 ------ src/NewTools-Playground/StPlaygroundPresenter.class.st | 6 ------ .../StSizeReporterPresenter.class.st | 6 ------ 5 files changed, 30 deletions(-) diff --git a/src/ColorPicker/SpColorCodePresenter.class.st b/src/ColorPicker/SpColorCodePresenter.class.st index a0850ed59..e8df1023d 100644 --- a/src/ColorPicker/SpColorCodePresenter.class.st +++ b/src/ColorPicker/SpColorCodePresenter.class.st @@ -46,12 +46,6 @@ SpColorCodePresenter >> chessPaintFor: aPoint [ ^ canvas asForm ] -{ #category : 'initialization' } -SpColorCodePresenter >> connectPresenters [ - - "rCodeInput whenTextChangedDo: [ self updateColorCode ] " -] - { #category : 'layout' } SpColorCodePresenter >> defaultLayout [ diff --git a/src/NewTools-MethodBrowsers/StMessageBrowser.class.st b/src/NewTools-MethodBrowsers/StMessageBrowser.class.st index 6993ac75d..d762b9f0a 100644 --- a/src/NewTools-MethodBrowsers/StMessageBrowser.class.st +++ b/src/NewTools-MethodBrowsers/StMessageBrowser.class.st @@ -91,12 +91,6 @@ StMessageBrowser class >> browseSendersOf: aSymbol [ ^ self browse: aSymbol senders asSendersOf: aSymbol ] -{ #category : 'accessing' } -StMessageBrowser class >> defaultPreferredExtent [ - - ^ 900@600 -] - { #category : 'instance creation - old' } StMessageBrowser class >> openMessageList: messageList name: aString autoSelect: aSelector refreshingBlockSelector: aRefreshingBlockSelector [ diff --git a/src/NewTools-Playground/StPlaygroundBindingsPresenter.class.st b/src/NewTools-Playground/StPlaygroundBindingsPresenter.class.st index 93cc8da39..b0d72069e 100644 --- a/src/NewTools-Playground/StPlaygroundBindingsPresenter.class.st +++ b/src/NewTools-Playground/StPlaygroundBindingsPresenter.class.st @@ -18,12 +18,6 @@ Class { #tag : 'View' } -{ #category : 'accessing' } -StPlaygroundBindingsPresenter class >> defaultPreferredExtent [ - - ^ (600@400) -] - { #category : 'accessing' } StPlaygroundBindingsPresenter class >> emptyMessage [ diff --git a/src/NewTools-Playground/StPlaygroundPresenter.class.st b/src/NewTools-Playground/StPlaygroundPresenter.class.st index f66d65f2f..5061efb3e 100644 --- a/src/NewTools-Playground/StPlaygroundPresenter.class.st +++ b/src/NewTools-Playground/StPlaygroundPresenter.class.st @@ -79,12 +79,6 @@ StPlaygroundPresenter class >> defaultExtent [ ^ (600@400) ] -{ #category : 'accessing' } -StPlaygroundPresenter class >> defaultPreferredExtent [ - - ^ (600@400) -] - { #category : 'world menu' } StPlaygroundPresenter class >> menuCommandOn: aBuilder [ diff --git a/src/NewTools-SystemReporter/StSizeReporterPresenter.class.st b/src/NewTools-SystemReporter/StSizeReporterPresenter.class.st index a596d1a8d..6271fa52c 100644 --- a/src/NewTools-SystemReporter/StSizeReporterPresenter.class.st +++ b/src/NewTools-SystemReporter/StSizeReporterPresenter.class.st @@ -17,12 +17,6 @@ Class { #tag : 'Base' } -{ #category : 'accessing' } -StSizeReporterPresenter class >> defaultPreferredExtent [ - - ^ 600@ 400 -] - { #category : 'accessing' } StSizeReporterPresenter >> baselineClassLoc [ ^ data at: #baselineClassLoc ifAbsent: [ self computeLocs. data at: #baselineClassLoc ]