Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Check Spec loading #16939

Closed
MarcusDenker opened this issue Jul 24, 2024 · 5 comments
Closed

[CI] Check Spec loading #16939

MarcusDenker opened this issue Jul 24, 2024 · 5 comments

Comments

@MarcusDenker
Copy link
Member

Bug description
One PR showed a load problem (this is #16928 )

MetacelloNotification: Loaded -> Spec2-Commander2 --- github://pharo-spec/Spec:Pharo13/src(4973383)
MetacelloNotification: Loaded -> Spec2-ListView --- github://pharo-spec/Spec:Pharo13/src(4973383)
Error: Package UNKNOWN depends on the following classes:
  SpMorphicListAdapter
  SpMorphicListDataSource
You must resolve these dependencies before you will be able to load these definitions: 
  SpMorphicListViewAdapter
  SpMorphicListViewAdapter>>#buildWidget
  SpMorphicListViewAdapter>>#newDataSource
  SpMorphicListViewAdapter>>#newTableWith:
  SpMorphicListViewDataSource
  SpMorphicListViewDataSource>>#cellColumn:row:

It is not yet clear if this is a real problem (after external pagages get changes, only the next random build of pharo will get those changes).

There where two PRs merged in spec:

pharo-spec/Spec#1573
pharo-spec/Spec#1565

@jecisc
Copy link
Member

jecisc commented Jul 24, 2024

I hope to fix it with this: pharo-spec/Spec#1575

@jecisc
Copy link
Member

jecisc commented Jul 24, 2024

I fixed the error reported but now there is another one. I'll check it

@jecisc
Copy link
Member

jecisc commented Jul 24, 2024

MetacelloNotification: Loaded -> Spec2-Commander2 --- github://pharo-spec/Spec:Pharo13/src(90dceb7)
MetacelloNotification: Loaded -> Spec2-ListView --- github://pharo-spec/Spec:Pharo13/src(90dceb7)
�[31mError: Package UNKNOWN depends on the following classes:
  SpAbstractListPresenterTest
You must resolve these dependencies before you will be able to load these definitions: 
  SpEasyListViewPresenterTest
  SpEasyListViewPresenterTest>>#classToTest
  SpEasyListViewPresenterTest>>#initializeTestedInstance
  SpEasyListViewPresenterTest>>#testHideHeaderTitleUnsetsTitle
  SpEasyListViewPresenterTest>>#testIconFor
  SpEasyListViewPresenterTest>>#testSetHeaderTitleHasTitle
  SpEasyListViewPresenterTest>>#testSetHeaderTitleSetsTitle
  SpEasyListViewPresenterTest>>#testWhenIconsChangedDo
  SpListViewPresenterTest
  SpListViewPresenterTest>>#classToTest
  SpListViewPresenterTest>>#initializeTestedInstance
  SpListViewPresenterTest>>#tearDown

�[0mMCPackageLoader(Object)>>notify:
MCPackageLoader>>warnAboutDependencies
MCPackageLoader>>validate

@jecisc
Copy link
Member

jecisc commented Jul 24, 2024

pharo-spec/Spec#1576

@jecisc
Copy link
Member

jecisc commented Jul 24, 2024

It's fixed

@jecisc jecisc closed this as completed Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants