Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tonel export of class trait can be wrong #16345

Closed
jecisc opened this issue Mar 25, 2024 · 4 comments · Fixed by #16487
Closed

Tonel export of class trait can be wrong #16345

jecisc opened this issue Mar 25, 2024 · 4 comments · Fixed by #16487
Labels
To fix before release Issure to fix before the upcoming Pharo release Type: Bug Version: Pharo 12

Comments

@jecisc
Copy link
Member

jecisc commented Mar 25, 2024

Since a few weeks/months in Pharo 12 it happens that the Tonel export of some code generates wrong class trait. It will be #classTraits : '{} + TraitedClass'.

This prevents the code from loading afterward and is not easy to catch.

This should be fixed before the release of P12.

@jecisc jecisc added Type: Bug Version: Pharo 12 To fix before release Issure to fix before the upcoming Pharo release labels Mar 25, 2024
@jecisc
Copy link
Member Author

jecisc commented Mar 25, 2024

Here is an example: c23a2fe

@PalumboN
Copy link
Collaborator

PalumboN commented Mar 29, 2024

Probably related to this merged PR: https://github.com/pharo-project/pharo/pull/15833/files

As it says this other issue: #16014

In your example, the DADependencyTreePresenter has no traits but there are up in the hierarchy.

I understand that #classTraits : '{} + TraitedClass' should not appear in the subclasses.

GitHub
When changing the superclass of spec tests in pharo-spec/Spec#1496, a release test broke. Completely unrelated to the original PR. ProperPackagesTest debug: #testPackageExtensionsStartsWithProperPa...

@estebanlm
Copy link
Member

is this still happening ?
(I did not have this problem recently)

@jecisc
Copy link
Member Author

jecisc commented Apr 8, 2024

I've not seen any fix for this integrated so I think it's probably still happening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
To fix before release Issure to fix before the upcoming Pharo release Type: Bug Version: Pharo 12
Projects
None yet
3 participants