Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

‘Close’ icon on tabs in System Browser gets clipped #16038

Closed
Rinzwind opened this issue Jan 26, 2024 · 2 comments · Fixed by #16295
Closed

‘Close’ icon on tabs in System Browser gets clipped #16038

Rinzwind opened this issue Jan 26, 2024 · 2 comments · Fixed by #16295
Labels
To fix before release Issure to fix before the upcoming Pharo release Version: Pharo 12

Comments

@Rinzwind
Copy link
Contributor

The ‘close’ icon on tabs in the System Browser gets clipped in Pharo 12 build 1258:

Build 1236 seems to be the last build in which the icons don’t get clipped:

I assume, but didn’t check, this is due to some of the changes in commit b64e3bc1df1b06f4 in the Spec repository.

@demarey demarey added Version: Pharo 12 To fix before release Issure to fix before the upcoming Pharo release labels Feb 15, 2024
@demarey
Copy link
Contributor

demarey commented Feb 23, 2024

I and @ISayarLu can confirm the problem started in image number 1237.
The close button is still present but has a ridiculous size of 2@18 instead of 16@18.

It was introduced by the merge of a PR in Spec integration branch: pharo-spec/Spec#1486
The code causing problems lies in src/Spec2-Adapters-Morphic/SpMorphicBoxLayoutCalculatorLeftToRight.class.st.
See pharo-spec/Spec@b64e3bc#diff-79065f23e35b422864e3fef686ade71d813e234eb22cb1ef8a955e34ba5d42a8L66-R78
reverting the method SpMorphicBoxLayoutCalculatorLeftToRight>>#doCalculateFor:in: fixes the problem but I do not think it is the right fix. @estebanlm Could you help?

@estebanlm
Copy link
Member

it will fix that but it will break other places :)
So I would say yes, is around there but removing is not the solution

estebanlm added a commit to estebanlm/pharo that referenced this issue Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
To fix before release Issure to fix before the upcoming Pharo release Version: Pharo 12
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants