Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DarkMode again, fw 4.31.19086 #120

Closed
jackiew1 opened this issue Jan 21, 2022 · 3 comments
Closed

DarkMode again, fw 4.31.19086 #120

jackiew1 opened this issue Jan 21, 2022 · 3 comments

Comments

@jackiew1
Copy link
Collaborator

jackiew1 commented Jan 21, 2022 •
edited
Loading

@pgaskin , In case you haven't seen MR yet, the change you made to make DarkMode work (posted here) seems to have disappeared from NickelMenu v5.3

Edit: Sorry didn't see that you'd already commented on this yesterday in #116
@pgaskin
Copy link
Owner

pgaskin commented Jan 21, 2022

Yes, it's currently in the elipsa branch.

@pgaskin
Copy link
Owner

pgaskin commented Jan 21, 2022

duplicate of #116

@pgaskin pgaskin closed this as completed Jan 21, 2022
@jackiew1
Copy link
Collaborator Author

jackiew1 commented Jan 21, 2022 •
edited
Loading

Yes, it's currently in the elipsa branch.

Sorry are you saying there's an existing version of KoboRoot.tgz where both DarkMode and the Highlighting issue in #119 are fixed?

Edit: OK, I've seen the relevant link on MR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pgaskin @jackiew1