Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to automatically check SS3 input files for PFMC groundfish ToR? #13

Open
iantaylor-NOAA opened this issue May 26, 2022 · 2 comments
Assignees
Labels
SS3 Stock Synthesis 3.3 (SS3) input or output files.

Comments

@iantaylor-NOAA
Copy link
Contributor

@brianlangseth-NOAA and I discussed this by email and he started this Google Doc a few weeks ago to gather ideas for what the checker could check: https://docs.google.com/document/d/1_bw81a0iF-BeP11kuPenqMGIZb1tYrh8JRqlvpK6rw8/edit

Feel free to add to the doc or comment here, especially as the team works through Stock Synthesis input files.

I'm imagining that the user experience would be something like

> PEPtools::check_inputs()
check_inputs() found 2 issues:
  1. starter line 29: max yr for sdreport outputs is -1 but should be -2 for endyr+Nforecastyrs
  2. forecast line 27: control rule method is 1 but should be 3: ramp does catch=f(SSB)

This function would focus on things that are specific to PFMC ToR, not general advise for Stock Synthesis (which could instead be added to the warning messages that SS3 returns).

@k-doering-NOAA
Copy link

It's none of my business, but I really love this idea!

@kellijohnson-NOAA
Copy link
Contributor

#21 is a duplicate of this issue. My bad 🤦.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SS3 Stock Synthesis 3.3 (SS3) input or output files.
Projects
None yet
Development

No branches or pull requests

4 participants