From 7cca7a32cc62cb8d0b03699c912e7b305ca74fb6 Mon Sep 17 00:00:00 2001 From: perkee Date: Mon, 3 Feb 2025 16:51:18 -0700 Subject: [PATCH] better message, arguably --- src/UseHtmlExtraNothing.elm | 2 +- tests/UseHtmlExtraNothingTest.elm | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/UseHtmlExtraNothing.elm b/src/UseHtmlExtraNothing.elm index a7b18a2..c936435 100644 --- a/src/UseHtmlExtraNothing.elm +++ b/src/UseHtmlExtraNothing.elm @@ -162,7 +162,7 @@ expressionVisitor node context = if ModuleNameLookupTable.moduleNameFor context.lookupTable firstNode == Just [ "Html" ] then ( [ Rule.error { message = "Replace `Html.text \"\" with Html.Extra.nothing" - , details = [ "We prefer Html.Extra.nothing" ] + , details = [ "We prefer Html.Extra.nothing when we must create an empty node." ] } (Node.range node) ] diff --git a/tests/UseHtmlExtraNothingTest.elm b/tests/UseHtmlExtraNothingTest.elm index d3ebf41..50cae9f 100644 --- a/tests/UseHtmlExtraNothingTest.elm +++ b/tests/UseHtmlExtraNothingTest.elm @@ -89,7 +89,7 @@ a = Html.text "" |> Review.Test.expectErrors [ Review.Test.error { message = "Replace `Html.text \"\" with Html.Extra.nothing" - , details = [ "We prefer Html.Extra.nothing" ] + , details = [ "We prefer Html.Extra.nothing when we must create an empty node." ] , under = "Html.text \"\"" } ] @@ -107,7 +107,7 @@ a = H.text "" |> Review.Test.expectErrors [ Review.Test.error { message = "Replace `Html.text \"\" with Html.Extra.nothing" - , details = [ "We prefer Html.Extra.nothing" ] + , details = [ "We prefer Html.Extra.nothing when we must create an empty node." ] , under = "H.text \"\"" } ] @@ -125,7 +125,7 @@ a = text "" |> Review.Test.expectErrors [ Review.Test.error { message = "Replace `Html.text \"\" with Html.Extra.nothing" - , details = [ "We prefer Html.Extra.nothing" ] + , details = [ "We prefer Html.Extra.nothing when we must create an empty node." ] , under = "text \"\"" } ] @@ -143,7 +143,7 @@ a = text "" |> Review.Test.expectErrors [ Review.Test.error { message = "Replace `Html.text \"\" with Html.Extra.nothing" - , details = [ "We prefer Html.Extra.nothing" ] + , details = [ "We prefer Html.Extra.nothing when we must create an empty node." ] , under = "text \"\"" } ]