Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default whosonfirst.sqlite to true #460

Closed
orangejulius opened this issue Aug 19, 2019 · 3 comments · Fixed by #487
Closed

Default whosonfirst.sqlite to true #460

orangejulius opened this issue Aug 19, 2019 · 3 comments · Fixed by #487
Assignees
@Joxit
Labels
enhancement question

Comments

@orangejulius
Copy link
Member

We have been testing the SQLite download option introduced in #417 for some time, and it appears to be pretty solid.

As far as I know, the SQLite databases are the preferred distribution method for WOF data going forward.

What is left before we consider setting whosonfirst.sqlite to true by default?
@orangejulius
Copy link
Member Author

There's at least one blocker for this: the wof-admin-lookup tests currently fail when sqlite is set to true: pelias/wof-admin-lookup#262

@Joxit Joxit self-assigned this Aug 27, 2019
This was referenced Aug 28, 2019
Merged
Merged
@Joxit
Copy link
Member

Joxit commented Aug 29, 2019

Now that pelias/wof-admin-lookup#262 is fixed, I think we can set SQLite by default 😄.

This was referenced Nov 25, 2019
Closed
Merged
Open
@orangejulius orangejulius mentioned this issue Dec 2, 2019
Closed
orangejulius added a commit that referenced this issue Jan 9, 2020
@orangejulius
feat(download): Filter out country-specific SQLite DBs
a3f9b8b 
The country-specific SQLite DBs currently available for download from
https://dist.whosonfirst.org have a few integrity issues. This causes
problems in Pelias such as addresses in NYC or Berlin not having proper
admin information.

The planet-wide SQLite DB, while a little out of date, is overall more
valid.

While in the long term we probably want to utilize the country-specific
DBs, for now it makes sense to filter them out.

Fixes #469
Connects #460
@orangejulius orangejulius mentioned this issue Jan 9, 2020
Closed
orangejulius added a commit that referenced this issue Jan 9, 2020
@orangejulius
feat(download): Filter out country-specific SQLite DBs
6449dcb 
The country-specific SQLite DBs currently available for download from
https://dist.whosonfirst.org have a few integrity issues. This causes
problems in Pelias such as addresses in NYC or Berlin not having proper
admin information.

The planet-wide SQLite DB, while a little out of date, is overall more
valid.

While in the long term we probably want to utilize the country-specific
DBs, for now it makes sense to filter them out.

Fixes #469
Connects #460
Fixes #437
@orangejulius
Copy link
Member Author

We've done lots of testing with SQLite DBs recently. They are definitely the way of the future and already work well today.

Two PRs left to merge before we can do this:

Should happen soon!

This was referenced Mar 9, 2020
Merged
Merged
@orangejulius orangejulius mentioned this issue Apr 21, 2020
Closed
Joxit added a commit that referenced this issue Apr 21, 2020
@Joxit
feat(sqlite): drop support for wof bundle
d7f5b51 
BREAKING CHANGE: drop support for wof bundles
BREAKING CHANGE: `imports.whosonfirst.sqlite` default to `true`

fixes #496
fixes #226
closes #460
orangejulius pushed a commit that referenced this issue Apr 23, 2020
@Joxit @orangejulius
feat(sqlite): Drop support for bundle downloads
d851218 
BREAKING CHANGE: Support for the bundle downloads (files ending in
`tar.bz2`) has been removed. Only SQLite downloads are supported and
the `whosonfirst` importer will now behave as if
`imports.whosonfirst.sqlite` is set to true.

fixes #496
fixes #226
closes #460
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Joxit Joxit

Labels
enhancement question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Download sqlite default endpoint to geocode.earth and remove bundle support pelias/whosonfirst
2 participants
@orangejulius @Joxit