From 18a190dc5c685a546eb0556c97afa91e7dde95f5 Mon Sep 17 00:00:00 2001 From: Kaushik Malapati Date: Mon, 9 Oct 2023 12:02:30 -0700 Subject: [PATCH 1/2] DOC: specify k2700 cpts are for ranges --- ...1174-k2700_specify_cpts_are_for_ranges.rst | 30 +++++++++++++++++++ pcdsdevices/pim.py | 16 +++++----- 2 files changed, 38 insertions(+), 8 deletions(-) create mode 100644 docs/source/upcoming_release_notes/1174-k2700_specify_cpts_are_for_ranges.rst diff --git a/docs/source/upcoming_release_notes/1174-k2700_specify_cpts_are_for_ranges.rst b/docs/source/upcoming_release_notes/1174-k2700_specify_cpts_are_for_ranges.rst new file mode 100644 index 00000000000..97927d5c877 --- /dev/null +++ b/docs/source/upcoming_release_notes/1174-k2700_specify_cpts_are_for_ranges.rst @@ -0,0 +1,30 @@ +1174 k2700_specify_cpts_are_for_ranges +################# + +API Breaks +---------- +- N/A + +Features +-------- +- N/A + +Device Updates +-------------- +- Added 'range' to names/docs of dcv, acv, dci, and aci components of K2700 + +New Devices +----------- +- N/A + +Bugfixes +-------- +- N/A + +Maintenance +----------- +- N/A + +Contributors +------------ +- N/A diff --git a/pcdsdevices/pim.py b/pcdsdevices/pim.py index 11d6e5243a7..deb39c6d74d 100644 --- a/pcdsdevices/pim.py +++ b/pcdsdevices/pim.py @@ -572,14 +572,14 @@ class K2700(BaseInterface, Device): doc='Identity (name) of this device') reading = Cpt(EpicsSignalRO, ":Reading", kind="normal", doc='Trigger and return a new measurement') - dcv = Cpt(EpicsSignalRO, ":GetDCV", kind="normal", - doc='DC voltage') - acv = Cpt(EpicsSignalRO, ":GetACV", kind="normal", - doc='AC voltage') - dci = Cpt(EpicsSignalRO, ":GetDCI", kind="normal", - doc='DC current') - aci = Cpt(EpicsSignalRO, ":GetACI", kind="normal", - doc='AC current') + dcv_range = Cpt(EpicsSignalRO, ":GetDCV", kind="normal", + doc='DC voltage range') + acv_range = Cpt(EpicsSignalRO, ":GetACV", kind="normal", + doc='AC voltage range') + dci_range = Cpt(EpicsSignalRO, ":GetDCI", kind="normal", + doc='DC current range') + aci_range = Cpt(EpicsSignalRO, ":GetACI", kind="normal", + doc='AC current range') class IM3L0_K2700(K2700): From ec934f398836be8a94d55a0d0034e4b736506dcc Mon Sep 17 00:00:00 2001 From: Kaushik Malapati Date: Tue, 10 Oct 2023 10:20:57 -0700 Subject: [PATCH 2/2] DOC: added component name changes to API Break section of release notes --- .../1174-k2700_specify_cpts_are_for_ranges.rst | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/source/upcoming_release_notes/1174-k2700_specify_cpts_are_for_ranges.rst b/docs/source/upcoming_release_notes/1174-k2700_specify_cpts_are_for_ranges.rst index 97927d5c877..6cf51069bf9 100644 --- a/docs/source/upcoming_release_notes/1174-k2700_specify_cpts_are_for_ranges.rst +++ b/docs/source/upcoming_release_notes/1174-k2700_specify_cpts_are_for_ranges.rst @@ -3,7 +3,10 @@ API Breaks ---------- -- N/A +- K2700.dcv renamed to K2700.dcv_range +- K2700.acv renamed to K2700.acv_range +- K2700.dci renamed to K2700.dci_range +- K2700.aci renamed to K2700.aci_range Features --------