Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate a post-uninstall step #316

Open
ZLLentz opened this issue Jan 29, 2024 · 0 comments
Open

Investigate a post-uninstall step #316

ZLLentz opened this issue Jan 29, 2024 · 0 comments

Comments

@ZLLentz
Copy link
Member

ZLLentz commented Jan 29, 2024

ecdsa has a security vulnerability, and even without this it isn't recommended for production code
it is installed incidentally by python-jose which will not use it because it has cryptography available
see https://pypi.org/project/python-jose/

This project has the following recommendation:

Due to complexities with setuptools, the native-python backend is always installed, even if you select a different backend on install. We recommend that you remove unnecessary dependencies in production.

And lists the following optional dependencies for when you have cryptography available:

  • rsa
  • ecdsa
  • pyasn1

We also have had other incidents with orphaned dependencies- maybe we need a post-uninstall step to handle these cases.

I'm not sure if this will play nicely with pip check... which will probably notice the packaging mistake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant