Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check repo scripts with shellcheck, flake8 #240

Open
ZLLentz opened this issue May 23, 2022 · 1 comment
Open

Check repo scripts with shellcheck, flake8 #240

ZLLentz opened this issue May 23, 2022 · 1 comment

Comments

@ZLLentz
Copy link
Member

ZLLentz commented May 23, 2022

We use these scripts a lot, lets make sure they are doing all the normal good practices.
My plan is to add a CI job that simply runs shellcheck and flake8 on the contents of deploy and scripts as appropriate.

In the context of some items which may be better as-is for this use case:

Can also add a # shellcheck disable=ERRID to explicitly say "I'm ok with this"
Originally posted by @klauer in #239 (comment)

@klauer
Copy link
Contributor

klauer commented May 23, 2022

I have shellcheck done in pre-commit for shared-dotfiles - it may be of use:
https://github.com/pcdshub/shared-dotfiles/blob/master/.pre-commit-config.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants