Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip paths during retrieval #58

Open
sbliven opened this issue May 2, 2024 · 0 comments
Open

Strip paths during retrieval #58

sbliven opened this issue May 2, 2024 · 0 comments
Labels
question Further information is requested

Comments

@sbliven
Copy link
Member

sbliven commented May 2, 2024

Summary

Should we change the behavior of datasetRetriever to strip leading components of the path when retrieving?

Current behavior

Say we have a dataset with creationLocation: /das/work/p12/p12345/data. When retrieving this with datasetRetriever PID retrieve/ it will actually put the dataset at retrieve/das/work/p12/p12335/data/. The user then needs to run mv retrieve/das/work/p12/p12335/* retrieve/; rm -r retrieve/das.

Proposed behavior

Several users have mentioned being annoyed by this behavior. They would prefer the dataset to be retrieved directly to retrieve/data.

Discussion

This current behavior the following advantages:

  • Datasets can be retrieved to their original location with datasetRetriever PID /
  • It works for datasets spread over multiple directories (specified by the ingestor fileListing.txt option)

Is there some way we could support the proposed behavior for the common single-folder case without breaking the multi-folder case? Maybe add a --skip-directories option or similar?

@sbliven sbliven added the question Further information is requested label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant