Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmptyState - enhance autofixer for when titleText and children are not present #764

Closed
thatblindgeye opened this issue Sep 10, 2024 · 1 comment · Fixed by #770
Closed
Assignees
Labels
codemod enhancement New feature or request
Milestone

Comments

@thatblindgeye
Copy link
Collaborator

Followup to #749. One of the issues found was that if there's no titleText or children for EmptyStateHeader, the autofixer we currently have doesn't run. We can try to provide an autofixer in this instance (the workaround consumer-side was passing titleText="" to EmptyState, which may not be ideal if we want to encourage consumers to pass a valid titleText).

@thatblindgeye thatblindgeye added enhancement New feature or request codemod labels Sep 10, 2024
@thatblindgeye thatblindgeye added this to the Penta final release milestone Sep 10, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Sep 10, 2024
@thatblindgeye thatblindgeye moved this from Needs triage to Ready to assign in PatternFly Issues Sep 10, 2024
@kmcfaul
Copy link
Contributor

kmcfaul commented Sep 11, 2024

Update the current EmptyState codemod to adjust for not requiring titleText anymore

@kmcfaul kmcfaul moved this from Ready to assign to Not started in PatternFly Issues Sep 12, 2024
@adamviktora adamviktora moved this from Not started to PR Review in PatternFly Issues Sep 18, 2024
@kmcfaul kmcfaul modified the milestones: Penta final release, 2024.Q4 Sep 26, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codemod enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants