Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-user-feedback - css import has changed #734

Closed
kmcfaul opened this issue Aug 9, 2024 · 0 comments · Fixed by #747
Closed

react-user-feedback - css import has changed #734

kmcfaul opened this issue Aug 9, 2024 · 0 comments · Fixed by #747
Assignees
Labels
Milestone

Comments

@kmcfaul
Copy link
Contributor

kmcfaul commented Aug 9, 2024

Codemod for patternfly/react-user-feedback#76

We probably want a codemod that detects if the FeedbackModal from the user-feedback package is being imported and throw a warning letting users know that the css import path has been updated. It's no longer an scss file that is internally referenced and the css file should be imported like so: import "@patternfly/react-user-feedback/src/Feedback/Feedback.css";.

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Aug 9, 2024
@thatblindgeye thatblindgeye added this to the Penta final release milestone Aug 13, 2024
@thatblindgeye thatblindgeye moved this from Needs triage to Ready to assign in PatternFly Issues Aug 13, 2024
@kmcfaul kmcfaul self-assigned this Aug 14, 2024
@kmcfaul kmcfaul moved this from Ready to assign to Not started in PatternFly Issues Aug 14, 2024
@kmcfaul kmcfaul moved this from Not started to In Progress in PatternFly Issues Aug 19, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants