Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The cleanup rule which removes unused imports isn't running for the v6 codemods. #656

Closed
wise-king-sullyman opened this issue Jun 6, 2024 · 0 comments · Fixed by #678
Closed

The cleanup rule which removes unused imports isn't running for the v6 codemods. #656

wise-king-sullyman opened this issue Jun 6, 2024 · 0 comments · Fixed by #678
Assignees
@wise-king-sullyman
Labels
codemod v6 alpha bug
Milestone
Penta beta release

Comments

@wise-king-sullyman
Copy link
Collaborator

wise-king-sullyman commented Jun 6, 2024 •
edited
Loading

I tested our v5 version of this rule in a consumers codebase and it seemed to work fine, we probably just need to do something so that it runs with the v6 rules.
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jun 6, 2024
@tlabaj tlabaj added the codemod label Jun 13, 2024
@tlabaj tlabaj added this to the Penta beta release milestone Jun 13, 2024
@tlabaj tlabaj moved this from Needs triage to On deck in PatternFly Issues Jun 13, 2024
@wise-king-sullyman wise-king-sullyman self-assigned this Jun 26, 2024
@wise-king-sullyman wise-king-sullyman moved this from On deck to In Progress in PatternFly Issues Jun 26, 2024
@wise-king-sullyman wise-king-sullyman mentioned this issue Jul 1, 2024
Merged
@wise-king-sullyman wise-king-sullyman moved this from In Progress to PR Review in PatternFly Issues Jul 1, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wise-king-sullyman wise-king-sullyman

Labels
codemod v6 alpha bug
Projects
PatternFly Issues
Archived in project
Milestone
Penta beta release
Development

Successfully merging a pull request may close this issue.

fix(noUnusedImports): Add unused import removal for v6 rules wise-king-sullyman/pf-codemods
2 participants
@wise-king-sullyman @tlabaj