Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner - replaced variant prop with color #647

Closed
thatblindgeye opened this issue May 23, 2024 · 0 comments · Fixed by #649
Closed

Banner - replaced variant prop with color #647

thatblindgeye opened this issue May 23, 2024 · 0 comments · Fixed by #649
Assignees
Labels

Comments

@thatblindgeye
Copy link
Collaborator

Follow up to breaking change PR patternfly/patternfly-react#9891

We should update the variant prop to color, unless the variant was default in which case we should remove the prop. The error message should also mention something along the lines of "if you used the variant prop for color, use color prop, otherwise use status prop if you were using variant to convey status" or something.

Required actions:

  1. Build codemod
  2. Build test
  3. Update readme with description & example
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues May 23, 2024
@thatblindgeye thatblindgeye self-assigned this May 23, 2024
@thatblindgeye thatblindgeye moved this from Needs triage to In Progress in PatternFly Issues May 23, 2024
@thatblindgeye thatblindgeye moved this from In Progress to PR Review in PatternFly Issues May 23, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant