Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various - Provide warnings for markup changes #643

Closed
thatblindgeye opened this issue May 21, 2024 · 0 comments · Fixed by #644
Closed

Various - Provide warnings for markup changes #643

thatblindgeye opened this issue May 21, 2024 · 0 comments · Fixed by #644
Assignees
Labels

Comments

@thatblindgeye
Copy link
Collaborator

thatblindgeye commented May 21, 2024

Follow up to breaking change PR patternfly/patternfly-react#10378

These could be/may be needed to split out into separate issues:

  • NotificationDrawerHeader: notificationDrawerHeadterTitle class is no longer applied to a Text component, but rather a native h1 element
  • SliderStep: CSS variable that gets applied was updated from sliderStepLeft to sliderStepInsetInlineStart
  • ToolbarItem: Either mention the chipgroup variant applies labelgroup class, or provide a fixer to replace chipgroup with labelgroup (depending on feedback in PR)
  • WizardFooter: updated to use ActionList wrapped around Buttons instead of just Buttons internally
  • WizardItem: markup changed
  • WizardToggle: markup changed when status is error
  • Th/Td: updated CSS variables from cssStickyCell[Left|Right] to cssStickyCellInline[Start|End]

Required actions:

  1. Build codemod
  2. Build test
  3. Update readme with description & example
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues May 21, 2024
@thatblindgeye thatblindgeye moved this from Needs triage to Ready to assign in PatternFly Issues May 21, 2024
@thatblindgeye thatblindgeye self-assigned this May 21, 2024
@thatblindgeye thatblindgeye moved this from Ready to assign to In Progress in PatternFly Issues May 21, 2024
@thatblindgeye thatblindgeye moved this from In Progress to PR Review in PatternFly Issues May 21, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant