Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding tests to existing codemods for dist imports #641

Closed
thatblindgeye opened this issue May 16, 2024 · 1 comment
Closed

Consider adding tests to existing codemods for dist imports #641

thatblindgeye opened this issue May 16, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@thatblindgeye
Copy link
Collaborator

Something we had done a bit more explicitly with v5 codemods is writing tests where the import path was ...dist/[esm|js].... We haven't been doing that as much for v6 and should consider doing so (also adding in imports from dist/dynamic/..., which was added in #639 ).
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues May 16, 2024
@thatblindgeye thatblindgeye added the enhancement New feature or request label May 20, 2024
@thatblindgeye
Copy link
Collaborator Author

Closing in favor of updating the purpose of #599 from just the chip deprecated rule to a general issue for all existing v6 rules.

@github-project-automation github-project-automation bot moved this from Needs triage to Done in PatternFly Issues May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
PatternFly Issues
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thatblindgeye