Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chip - isReadOnly prop does not exist on Label #634

Closed
wise-king-sullyman opened this issue May 10, 2024 · 1 comment · Fixed by #653
Closed

Chip - isReadOnly prop does not exist on Label #634

wise-king-sullyman opened this issue May 10, 2024 · 1 comment · Fixed by #653
Assignees
@wise-king-sullyman
Labels
codemod v6 alpha bug
Milestone
Penta beta release

Comments

@wise-king-sullyman
Copy link
Collaborator

It seems like when we convert a chip to a label we aren't accounting for the isReadOnly prop existing on the Chip but not on the Label.
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues May 10, 2024
@thatblindgeye
Copy link
Collaborator

We should remove isReadOnly when Chip is converted to Label

@thatblindgeye thatblindgeye moved this from Needs triage to Not started in PatternFly Issues May 20, 2024
@thatblindgeye thatblindgeye added this to the Penta beta release milestone May 20, 2024
@wise-king-sullyman wise-king-sullyman mentioned this issue May 29, 2024
Merged
@wise-king-sullyman wise-king-sullyman moved this from Not started to PR Review in PatternFly Issues May 29, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wise-king-sullyman wise-king-sullyman

Labels
codemod v6 alpha bug
Projects
PatternFly Issues
Archived in project
Milestone
Penta beta release
Development

Successfully merging a pull request may close this issue.

fix(Chip): Remove isReadOnly prop during label conversion wise-king-sullyman/pf-codemods
2 participants
@wise-king-sullyman @thatblindgeye