Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PageSection - PageSectionVariants enum isn't picked up by the PageSection variant prop codemod #633

Closed
wise-king-sullyman opened this issue May 9, 2024 · 0 comments · Fixed by #657
Closed

PageSection - PageSectionVariants enum isn't picked up by the PageSection variant prop codemod #633

wise-king-sullyman opened this issue May 9, 2024 · 0 comments · Fixed by #657
Assignees
@thatblindgeye
Labels
bug Something isn't working codemod v6 alpha bug

Comments

@wise-king-sullyman
Copy link
Collaborator

wise-king-sullyman commented May 9, 2024 •
edited
Loading

The PageSection variant prop codemod does not detect usage of the PageSectionVariant enum, ideally it would both detect and auto fix the variant prop appropriately.

Required actions:

  1. Build codemod
  2. Build test
  3. Update readme with description & example
@wise-king-sullyman wise-king-sullyman added bug Something isn't working v6 alpha bug labels May 9, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues May 9, 2024
@wise-king-sullyman wise-king-sullyman changed the title PageSection - PageSectionVariants enum isn't auto fixed by the PageSection variant prop codemod PageSection - PageSectionVariants enum isn't picked up by the PageSection variant prop codemod May 9, 2024
@thatblindgeye thatblindgeye self-assigned this May 9, 2024
@thatblindgeye thatblindgeye moved this from Needs triage to Not started in PatternFly Issues May 20, 2024
@thatblindgeye thatblindgeye mentioned this issue Jun 6, 2024
Merged
@thatblindgeye thatblindgeye moved this from Not started to PR Review in PatternFly Issues Jun 6, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thatblindgeye thatblindgeye

Labels
bug Something isn't working codemod v6 alpha bug
Projects
PatternFly Issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(PageSection): updated logic to account for variant enum thatblindgeye/pf-codemods
2 participants
@wise-king-sullyman @thatblindgeye