Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - components imported in the format <package name>/dist/dynamic/components/<component name> aren't picked up by the codemods #632

Closed
wise-king-sullyman opened this issue May 9, 2024 · 2 comments
Assignees
Labels
bug Something isn't working codemod v6 alpha bug

Comments

@wise-king-sullyman
Copy link
Collaborator

Components imported in the format <package name>/dist/dynamic/components/<component name> aren't picked up by the codemods

Other dynamic paths could also be issues.

This issue should update all of our v6 codemods to apply for dynamic import paths, ideally via a helper or something if possible so that manual changes aren't required in every rule.

Required actions:

  1. Build codemod
  2. Build test
  3. Update readme with description & example
@thatblindgeye
Copy link
Collaborator

We should check if the updates made in #640 will resolve this

@thatblindgeye thatblindgeye self-assigned this May 20, 2024
@thatblindgeye thatblindgeye moved this from Needs triage to Not started in PatternFly Issues May 20, 2024
@wise-king-sullyman
Copy link
Collaborator Author

Closed as part of #640

@github-project-automation github-project-automation bot moved this from Not started to Done in PatternFly Issues Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working codemod v6 alpha bug
Projects
Archived in project
Development

No branches or pull requests

2 participants