Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EmptyState - support icons passed directly to EmptyStateHeader #595

Closed
Tracked by #176
wise-king-sullyman opened this issue Feb 27, 2024 · 0 comments · Fixed by #612
Closed
Tracked by #176

EmptyState - support icons passed directly to EmptyStateHeader #595

wise-king-sullyman opened this issue Feb 27, 2024 · 0 comments · Fixed by #612
Assignees
@adamviktora
Labels
codemod
Milestone
Penta beta release

Comments

@wise-king-sullyman
Copy link
Collaborator

Follow up to PR #582

The current implementation doesn't support handling icons which were passed directly to the EmptyStateHeader rather than being wrapped in an EmptyStateIcon container, this issue should address that potential issue.
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Feb 27, 2024
@wise-king-sullyman wise-king-sullyman mentioned this issue Feb 27, 2024
Merged
@wise-king-sullyman wise-king-sullyman added this to the Penta beta release milestone Feb 27, 2024
@andrew-ronaldson andrew-ronaldson mentioned this issue Feb 29, 2024
Closed
@adamviktora adamviktora moved this from Needs triage to In Progress in PatternFly Issues Mar 13, 2024
@adamviktora adamviktora mentioned this issue Mar 14, 2024
Merged
@adamviktora adamviktora moved this from In Progress to PR Review in PatternFly Issues Mar 14, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamviktora adamviktora

Labels
codemod
Projects
PatternFly Issues
Archived in project
Milestone
Penta beta release
Development

Successfully merging a pull request may close this issue.

feat(EmptyState): support icons passed directly to EmptyStateHeader adamviktora/pf-codemods
2 participants
@wise-king-sullyman @adamviktora