Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NotificationBadge - warn consumers about markup changes #558

Closed
wise-king-sullyman opened this issue Jan 30, 2024 · 0 comments · Fixed by #592
Closed

NotificationBadge - warn consumers about markup changes #558

wise-king-sullyman opened this issue Jan 30, 2024 · 0 comments · Fixed by #592
Assignees
@Dominik-Petrik
Labels
codemod
Milestone
Penta alpha release

Comments

@wise-king-sullyman
Copy link
Collaborator

Follow up to breaking change PR patternfly/patternfly-react#10020

We need to warn consumers that notification badge has been updated to internally use the stateful button and thus will have some markup changes.

Required actions:

  1. Build codemod
  2. Build test
  3. Update readme with description & example
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jan 30, 2024
@tlabaj tlabaj added the codemod label Feb 14, 2024
@tlabaj tlabaj added this to the Penta alpha release milestone Feb 14, 2024
@wise-king-sullyman wise-king-sullyman moved this from Needs triage to Not started in PatternFly Issues Feb 14, 2024
@mfrances17 mfrances17 self-assigned this Feb 16, 2024
@mfrances17 mfrances17 moved this from Not started to In Progress in PatternFly Issues Feb 19, 2024
@mfrances17 mfrances17 moved this from In Progress to Not started in PatternFly Issues Feb 19, 2024
@mfrances17 mfrances17 removed their assignment Feb 19, 2024
@Dominik-Petrik Dominik-Petrik self-assigned this Feb 20, 2024
@Dominik-Petrik Dominik-Petrik mentioned this issue Feb 27, 2024
Merged
@github-project-automation github-project-automation bot moved this from Not started to Done in PatternFly Issues Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dominik-Petrik Dominik-Petrik

Labels
codemod
Projects
PatternFly Issues
Archived in project
Milestone
Penta alpha release
Development

Successfully merging a pull request may close this issue.

feat(NotificationBadge) warn about markup updated Dominik-Petrik/pf-codemods
4 participants
@wise-king-sullyman @mfrances17 @tlabaj @Dominik-Petrik