Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs - Penta updates #555

Closed
thatblindgeye opened this issue Jan 26, 2024 · 0 comments · Fixed by #578
Closed

Tabs - Penta updates #555

thatblindgeye opened this issue Jan 26, 2024 · 0 comments · Fixed by #578
Assignees
Labels

Comments

@thatblindgeye
Copy link
Collaborator

  • feat(Tabs): consumed Penta updates patternfly-react#10044
    • Tabs: removed the light300 variant and replaced with secondary
    • Tabs: renamed isSecondary prop to isSubtab
    • Tabs: replaced the left/right scroll buttons with Button components, moved the tabsScrollButton class to a wrapper div around the buttons, removed secondary styling from the scroll buttons when isSubtab/isSecondary is true (probably just a warning for this, unless we batch all of this in a single codemod)

Required actions:

  1. Build codemod
  2. Build test
  3. Update readme with description & example
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jan 26, 2024
@tlabaj tlabaj added the codemod label Feb 14, 2024
@tlabaj tlabaj added this to the Penta alpha release milestone Feb 14, 2024
@wise-king-sullyman wise-king-sullyman moved this from Needs triage to In Progress in PatternFly Issues Feb 14, 2024
@wise-king-sullyman wise-king-sullyman moved this from In Progress to Not started in PatternFly Issues Feb 14, 2024
@thatblindgeye thatblindgeye self-assigned this Feb 15, 2024
@thatblindgeye thatblindgeye moved this from Not started to In Progress in PatternFly Issues Feb 19, 2024
@thatblindgeye thatblindgeye moved this from In Progress to PR Review in PatternFly Issues Feb 19, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants